chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2810323002: [Payments] Add metric for when Pr UI is skipped.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2810323002: [Payments] Add metric for when Pr UI is skipped. (Closed)

Patch Set: Use the BooleanSkipped enum Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 843622cc9117feead717a635970a473b62dbf983..3a39415c32078db28fa571d0bed43ecdf84b25b0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -598,8 +598,8 @@ public class PaymentRequestImpl

mDidRecordShowEvent = true;

mShouldRecordAbortReason = true;

- recordSuccessFunnelHistograms("Shown");

- mJourneyLogger.setEventOccurred(JourneyLogger.EVENT_SHOWN);

+ recordSuccessFunnelHistograms("SkippedShow");

+ mJourneyLogger.setEventOccurred(JourneyLogger.EVENT_SKIPPED_SHOW);

mJourneyLogger.setShowCalled();

onPayClicked(null /* selectedShippingAddress */, null /* selectedShippingOption */,