[Payments] Format contact detail phone desktop

[Payments] Format contact detail phone desktop

BUG=711002
Review-Url: https://codereview.chromium.org/2810293002
Cr-Commit-Position: refs/heads/master@{#464186}
Committed: https://chromium.googlesource.com/chromium/src/+/bb6ed135cfa7cc92153e12eecf525277ab085ed6

[sebsg, 2017-04-12 18:12:28]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:13:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 18:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 18:25:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sebsg, 2017-04-12 18:30:09]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:30:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 19:44:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 19:44:31]

Dry run: This issue passed the CQ dry run.

[sebsg, 2017-04-12 20:17:56]

The CQ bit was checked by sebsg@chromium.org to run a CQ dry run

[sebsg, 2017-04-12 20:18:02]

Patchset #2 (id:20001) has been deleted

[sebsg, 2017-04-12 20:18:15]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-12 20:18:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sebsg, 2017-04-12 20:18:39]

Description was changed from

==========
[Payments] WIP format contact detail phone desktop

BUG=
==========

to

==========
[Payments] Format contact detail phone desktop

BUG=711002
==========

[sebsg, 2017-04-12 20:33:21]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2017-04-12 20:33:21]

Hi Math, PTAL?

BTW when my two phone formatting CLs land I'll move the formatting function to a
better location that everyone can reuse.

[Mathieu, 2017-04-12 21:03:30]

lgtm

https://codereview.chromium.org/2810293002/diff/40001/components/payments/con...
File components/payments/content/payment_response_helper.cc (right):

https://codereview.chromium.org/2810293002/diff/40001/components/payments/con...
components/payments/content/payment_response_helper.cc:127: const std::string
original_number =
TODO to move the code

https://codereview.chromium.org/2810293002/diff/40001/components/payments/con...
components/payments/content/payment_response_helper.cc:141:
payment_response->payer_phone = original_number;
we really shouldn't get here, but coordinate with Tommy to know whether it's
possible to have an invalid phone number this late in the payment process

[commit-bot: I haz the power, 2017-04-12 21:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:05:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sebsg, 2017-04-12 21:11:50]

sebsg@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[sebsg, 2017-04-12 21:11:50]

Anthony, could you please take a look at the browser test? Thanks!

[anthonyvd, 2017-04-12 21:13:32]

browsertests lgtm

[sebsg, 2017-04-12 21:13:52]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2017-04-12 21:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2810293002/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-12 21:14:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:52:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492031632718440,
"parent_rev": "13c6d451eb9672278e1d2b472a04c7d21d8f2175", "commit_rev":
"bb6ed135cfa7cc92153e12eecf525277ab085ed6"}

[commit-bot: I haz the power, 2017-04-12 22:53:04]

Description was changed from

==========
[Payments] Format contact detail phone desktop

BUG=711002
==========

to

==========
[Payments] Format contact detail phone desktop

BUG=711002

Review-Url: https://codereview.chromium.org/2810293002
Cr-Commit-Position: refs/heads/master@{#464186}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb6ed135cfa7cc92153e12eecf52...
==========

[commit-bot: I haz the power, 2017-04-12 22:53:05]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bb6ed135cfa7cc92153e12eecf52...