[Payments] Format contact detail phone desktop

components/payments/content/payment_response_helper.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/content/payment_response_helper.h"
 
 #include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_profile.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/payments/content/payment_request_spec.h"
+#include "third_party/libphonenumber/phonenumber_api.h"
 
 namespace payments {
 
+namespace {
+
+using ::i18n::phonenumbers::PhoneNumberUtil;
+
+}  // namespace
+
 PaymentResponseHelper::PaymentResponseHelper(
     const std::string& app_locale,
     PaymentRequestSpec* spec,
     PaymentInstrument* selected_instrument,
     autofill::AutofillProfile* selected_shipping_profile,
     autofill::AutofillProfile* selected_contact_profile,
     Delegate* delegate)
     : app_locale_(app_locale),
       spec_(spec),
       delegate_(delegate),
@@ skipping 80 matching lines @@
         base::UTF16ToUTF8(selected_contact_profile_->GetInfo(
             autofill::AutofillType(autofill::NAME_FULL), app_locale_));
   }
   if (spec_->request_payer_email()) {
     DCHECK(selected_contact_profile_);
     payment_response->payer_email = base::UTF16ToUTF8(
         selected_contact_profile_->GetRawInfo(autofill::EMAIL_ADDRESS));
   }
   if (spec_->request_payer_phone()) {
     DCHECK(selected_contact_profile_);
-    // TODO(crbug.com/705945): Format phone number according to spec.
-    payment_response->payer_phone =
-        base::UTF16ToUTF8(selected_contact_profile_->GetRawInfo(
-            autofill::PHONE_HOME_WHOLE_NUMBER));
+
+    // Try to format the phone number to the E.164 format to send in the Payment
+    // Response, as defined in the Payment Request spec. If it's not possible,
+    // send the original. More info at:
+    // https://w3c.github.io/browser-payment-api/#paymentrequest-updated-algorithm
+    const std::string original_number =

[Mathieu, 2017/04/12 21:03:30]

TODO to move the code

+        base::UTF16ToUTF8(selected_contact_profile_->GetInfo(
+            autofill::AutofillType(autofill::PHONE_HOME_WHOLE_NUMBER),
+            app_locale_));
+    i18n::phonenumbers::PhoneNumber parsed_number;
+    PhoneNumberUtil* phone_number_util = PhoneNumberUtil::GetInstance();
+    if (phone_number_util->Parse(original_number, "US", &parsed_number) ==
+        ::i18n::phonenumbers::PhoneNumberUtil::NO_PARSING_ERROR) {
+      std::string formatted_number;
+      phone_number_util->Format(parsed_number,
+                                PhoneNumberUtil::PhoneNumberFormat::E164,
+                                &formatted_number);
+      payment_response->payer_phone = formatted_number;
+    } else {
+      payment_response->payer_phone = original_number;

[Mathieu, 2017/04/12 21:03:30]

we really shouldn't get here, but coordinate with Tommy to know whether it's
possible to have an invalid phone number this late in the payment process

+    }
   }
 
   delegate_->OnPaymentResponseReady(std::move(payment_response));
 }
 
 }  // namespace payments