Recursively find all tests in a repo.

Recursively find all tests in a git repo.

This method is necessary to allow good code organization (i.e., unittests live
adjacent to the source files they test) in the new infra.git repository.

R=maruel@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270564

[M-A Ruel, 2014-05-14 00:20:57]

https://codereview.chromium.org/281013002/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/281013002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:572: def curry_check(whitelist, blacklist):
This is not necessary, the values are bound anyhow.

https://codereview.chromium.org/281013002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:587: ['git', 'rev-parse', '--show-toplevel'],
cwd=root).strip()
That's not how I thought about doing it, my take was to add a method to
GitChange to run "git ls-files -- .", cwd=self.RepositoryRoot() and return its
output as a list, which would make this functionality reusable.

[agable, 2014-05-14 22:43:19]

https://codereview.chromium.org/281013002/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/281013002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:572: def curry_check(whitelist, blacklist):
On 2014/05/14 00:20:57, M-A Ruel wrote:
> This is not necessary, the values are bound anyhow.

But but but I have to pay honor to Haskell Curry!

https://codereview.chromium.org/281013002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:587: ['git', 'rev-parse', '--show-toplevel'],
cwd=root).strip()
On 2014/05/14 00:20:57, M-A Ruel wrote:
> That's not how I thought about doing it, my take was to add a method to
> GitChange to run "git ls-files -- .", cwd=self.RepositoryRoot() and return its
> output as a list, which would make this functionality reusable.

PTAL. I added one for SVN too.

[M-A Ruel, 2014-05-15 01:45:41]

lgtm

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py#new...
presubmit_support.py:874: raise NotImplementedError
raise NotImplementedError()
otherwise you raise the type, not an instance. It oddly works but it's not
semantically correct. And we know how semantically correct this code must
remain. :)

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py#new...
presubmit_support.py:973: """List all files under source control in the repo."""
Lists

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py#new...
presubmit_support.py:984: """List all files under source control in the repo."""
Lists

[agable, 2014-05-15 01:56:31]

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py#new...
presubmit_support.py:973: """List all files under source control in the repo."""
On 2014/05/15 01:45:41, M-A Ruel wrote:
> Lists

PEP-257: The docstring is a phrase ending in a period. It prescribes the
function or method's effect as a command ("Do this", "Return that"), not as a
description; e.g. don't write "Returns the pathname ...".

Also, matching surrounding style ("Get modified...").

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py#new...
presubmit_support.py:984: """List all files under source control in the repo."""
On 2014/05/15 01:45:41, M-A Ruel wrote:
> Lists

See above.

[agable, 2014-05-15 01:57:23]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2014-05-15 01:57:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/agable@chromium.org/281013002/40001

[agable, 2014-05-15 01:57:41]

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/281013002/diff/20001/presubmit_support.py#new...
presubmit_support.py:874: raise NotImplementedError
On 2014/05/15 01:45:41, M-A Ruel wrote:
> raise NotImplementedError()
> otherwise you raise the type, not an instance. It oddly works but it's not
> semantically correct. And we know how semantically correct this code must
> remain. :)

Done.

[commit-bot: I haz the power, 2014-05-15 01:59:17]

Change committed as 270564