Recursively find all tests in a repo.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 544 matching lines @@
     if env:
       kwargs['env'] = env
     results.append(input_api.Command(
         name=unit_test,
         cmd=cmd,
         kwargs=kwargs,
         message=message_type))
   return results
 
 
+def GetGitUnitTestsRecursively(input_api, output_api, directory,
+                               whitelist, blacklist):
+  """Gets all files in the directory tree (git repo) that match the whitelist.
+
+  Restricts itself to only find files within the Change's source repo, not
+  dependencies.
+  """
+  def curry_check(whitelist, blacklist):

[M-A Ruel, 2014/05/14 00:20:57]

This is not necessary, the values are bound anyhow.

[agable, 2014/05/14 22:43:20]

But but but I have to pay honor to Haskell Curry!

+    def check(filename):
+      return (any(input_api.re.match(f, filename) for f in whitelist) and
+              not any(input_api.re.match(f, filename) for f in blacklist))
+    return check
+  check = curry_check(whitelist, blacklist)
+
+  tests = []
+
+  repo_root = input_api.change.RepositoryRoot()
+  toplevel = input_api.os_path.abspath(
+      input_api.os_path.join(input_api.PresubmitLocalPath(), directory))
+  to_run = found = 0
+  for root, dirs, files in input_api.os_walk(toplevel):
+    git_toplevel = input_api.subprocess.check_output(
+          ['git', 'rev-parse', '--show-toplevel'], cwd=root).strip()

[M-A Ruel, 2014/05/14 00:20:57]

That's not how I thought about doing it, my take was to add a method to
GitChange to run "git ls-files -- .", cwd=self.RepositoryRoot() and return its
output as a list, which would make this functionality reusable.

[agable, 2014/05/14 22:43:20]

PTAL. I added one for SVN too.

+    if git_toplevel != repo_root:
+      del dirs[:]
+      continue
+    for name in files:
+      found += 1
+      fullname = input_api.os_path.join(root, name)
+      if check(fullname):
+        to_run += 1
+        tests.append(fullname)
+  input_api.logging.debug('Found %d files, running %d' % (found, to_run))
+  if not to_run:
+    return [
+        output_api.PresubmitPromptWarning(
+          'Out of %d files, found none that matched w=%r, b=%r in directory %s'
+          % (found, whitelist, blacklist, directory))
+    ]
+
+  return GetUnitTests(input_api, output_api, tests)
+
+
 def GetPythonUnitTests(input_api, output_api, unit_tests):
   """Run the unit tests out of process, capture the output and use the result
   code to determine success.
 
   DEPRECATED.
   """
   # We don't want to hinder users from uploading incomplete patches.
   if input_api.is_committing:
     message_type = output_api.PresubmitError
   else:
@@ skipping 162 matching lines @@
   # Passing py files one at time is slower and can produce
   # different results.  input_api.verbose used to be used
   # to enable this behaviour but differing behaviour in
   # verbose mode is not desirable.
   # Leave this unreachable code in here so users can make
   # a quick local edit to diagnose pylint issues more
   # easily.
   if True:
     return [GetPylintCmd(files)]
   else:
-    return map(GetPylintCmd, files)
+    return map(lambda x: GetPylintCmd([x]), files)
 
 
 def RunPylint(input_api, *args, **kwargs):
   """Legacy presubmit function.
 
   For better performance, get all tests and then pass to
   input_api.RunTests.
   """
   return input_api.RunTests(GetPylint(input_api, *args, **kwargs), False)
 
@@ skipping 306 matching lines @@
 def CheckPatchFormatted(input_api, output_api):
   import git_cl
   cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]
   code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)
   if code == 2:
     return [output_api.PresubmitPromptWarning(
       'Your patch is not formatted, please run git cl format.')]
   # As this is just a warning, ignore all other errors if the user
   # happens to have a broken clang-format, doesn't use git, etc etc.
   return []