Recursively find all tests in a repo.

presubmit_support.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.8.0'
 
@@ skipping 851 matching lines @@
     as an absolute path.
     """
     return self._local_root
 
   def __getattr__(self, attr):
     """Return tags directly as attributes on the object."""
     if not re.match(r"^[A-Z_]*$", attr):
       raise AttributeError(self, attr)
     return self.tags.get(attr)
 
+  def AllFiles(self, root=None):
+    """List all files under source control in the repo."""
+    raise NotImplementedError

[M-A Ruel, 2014/05/15 01:45:41]

raise NotImplementedError()
otherwise you raise the type, not an instance. It oddly works but it's not
semantically correct. And we know how semantically correct this code must
remain. :)

[agable, 2014/05/15 01:57:42]

Done.

+
   def AffectedFiles(self, include_dirs=False, include_deletes=True,
                     file_filter=None):
     """Returns a list of AffectedFile instances for all files in the change.
 
     Args:
       include_deletes: If false, deleted files will be filtered out.
       include_dirs: True to include directories in the list
       file_filter: An additional filter to apply.
 
     Returns:
@@ skipping 76 matching lines @@
       all_modified_files.extend(
           [os.path.join(self.RepositoryRoot(), f[1]) for f in cl])
     return all_modified_files
 
   def GetModifiedFiles(self):
     """Get modified files in the current CL."""
     changelists = self._GetChangeLists()
     return [os.path.join(self.RepositoryRoot(), f[1])
             for f in changelists[self.Name()]]
 
+  def AllFiles(self, root=None):
+    """List all files under source control in the repo."""

[M-A Ruel, 2014/05/15 01:45:41]

Lists

[agable, 2014/05/15 01:56:31]

PEP-257: The docstring is a phrase ending in a period. It prescribes the
function or method's effect as a command ("Do this", "Return that"), not as a
description; e.g. don't write "Returns the pathname ...".

Also, matching surrounding style ("Get modified...").

+    root = root or self.RepositoryRoot()
+    return subprocess.check_output(
+        ['svn', 'ls', '-R', '.'], cwd=root).splitlines()
+
 
 class GitChange(Change):
   _AFFECTED_FILES = GitAffectedFile
   scm = 'git'
 
+  def AllFiles(self, root=None):
+    """List all files under source control in the repo."""

[M-A Ruel, 2014/05/15 01:45:41]

Lists

[agable, 2014/05/15 01:56:31]

See above.

+    root = root or self.RepositoryRoot()
+    return subprocess.check_output(
+        ['git', 'ls-files', '--', '.'], cwd=root).splitlines()
+
 
 def ListRelevantPresubmitFiles(files, root):
   """Finds all presubmit files that apply to a given set of source files.
 
   If inherit-review-settings-ok is present right under root, looks for
   PRESUBMIT.py in directories enclosing root.
 
   Args:
     files: An iterable container containing file paths.
     root: Path where to stop searching.
@@ skipping 669 matching lines @@
   except PresubmitFailure, e:
     print >> sys.stderr, e
     print >> sys.stderr, 'Maybe your depot_tools is out of date?'
     print >> sys.stderr, 'If all fails, contact maruel@'
     return 2
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(Main(None))