MD-Settings: A11y - Label drop down menus.

MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG=603620, 626882
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[hcarmona, 2017-04-12 00:16:38]

Description was changed from

==========
MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG=603620
==========

to

==========
MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG=603620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2017-04-12 00:16:42]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 00:17:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-04-12 00:26:34]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-04-12 00:26:35]

lgtm

https://codereview.chromium.org/2810003003/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2810003003/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1672:
{"siteSettingsCameraLabel", IDS_SETTINGS_SITE_SETTINGS_CAMERA_LABEL},
nit: alphabetize these by key, not IDS_

[hcarmona, 2017-04-12 00:36:41]

https://codereview.chromium.org/2810003003/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2810003003/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1672:
{"siteSettingsCameraLabel", IDS_SETTINGS_SITE_SETTINGS_CAMERA_LABEL},
On 2017/04/12 00:26:35, Dan Beam wrote:
> nit: alphabetize these by key, not IDS_

List isn't alphabetized.
Should I group them together or alphabetize the whole list?

[hcarmona, 2017-04-12 00:41:28]

Description was changed from

==========
MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG=603620
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG=603620,626882
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-12 00:50:57]

https://codereview.chromium.org/2810003003/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2810003003/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1672:
{"siteSettingsCameraLabel", IDS_SETTINGS_SITE_SETTINGS_CAMERA_LABEL},
On 2017/04/12 00:36:41, hcarmona wrote:
> On 2017/04/12 00:26:35, Dan Beam wrote:
> > nit: alphabetize these by key, not IDS_
> 
> List isn't alphabetized.
> Should I group them together or alphabetize the whole list?

some sane order would be nice

definitely optional

[commit-bot: I haz the power, 2017-04-12 01:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 01:38:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[stevenjb, 2017-04-12 16:33:26]

lgtm

[Dan Beam, 2017-04-12 16:40:40]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:41:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 16:53:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:53:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hcarmona, 2017-04-12 22:38:13]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2017-04-12 22:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2810003003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-12 22:38:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 01:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:38:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-04-13 02:32:19]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:33:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 04:16:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492050739341370,
"parent_rev": "cf655c64cc8f79abcffe366fea0358decb03e6fd", "commit_rev":
"ff2e5c72ba330412f724b23e2b79d302460060ef"}

[commit-bot: I haz the power, 2017-04-13 04:22:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492050739341370,
"parent_rev": "ff2e5c72ba330412f724b23e2b79d302460060ef", "commit_rev":
"ee790118acaf41b85ab9e7e09a294b3f7863bf79"}

[commit-bot: I haz the power, 2017-04-13 04:27:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492050739341370,
"parent_rev": "ff2e5c72ba330412f724b23e2b79d302460060ef", "commit_rev":
"ee790118acaf41b85ab9e7e09a294b3f7863bf79"}

[commit-bot: I haz the power, 2017-04-13 04:32:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 04:32:04]

Failed to commit the patch.

[Dan Beam, 2017-04-13 15:41:50]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-13 15:42:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 15:51:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 15:51:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hcarmona, 2017-04-13 16:57:45]

Closed the CL because it landed.