chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html - Issue 2810003003: MD-Settings: A11y - Label drop down menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

Issue 2810003003: MD-Settings: A11y - Label drop down menus. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/display.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

index 8f3e8aabfec2f90064f6028f6c7fd0f34370eebb..0c3bd14745eb32c0ad3a4eb7bb0b48a3921161d0 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

@@ -107,7 +107,8 @@

<div id="select-label">$i18n{addressCountry}</div>

<select class="md-select address-column long"

- value="[[countryCode_]]" on-change="onCountryChange_">

+ aria-labelledby="select-label"

+ value="[[countryCode_]]" on-change="onCountryChange_">

<option value="[[getCode_(item)]]"