Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: chrome/browser/resources/settings/device_page/display.html

Issue 2810003003: MD-Settings: A11y - Label drop down menus. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/display.html
diff --git a/chrome/browser/resources/settings/device_page/display.html b/chrome/browser/resources/settings/device_page/display.html
index 6491360f4cbbc8ab47b1b4451d183b4d5250c6c5..06923938748234d8c72fdab77dab5ef72f821db6 100644
--- a/chrome/browser/resources/settings/device_page/display.html
+++ b/chrome/browser/resources/settings/device_page/display.html
@@ -118,9 +118,12 @@
<template is="dom-if" restamp
if="[[showDisplaySelectMenu_(displays, selectedDisplay)]]">
<div class="settings-box embedded">
- <div class="start">$i18n{displayScreenTitle}</div>
+ <div id="displayScreenTitle" class="start">
+ $i18n{displayScreenTitle}
+ </div>
<div class="md-select-wrapper">
<select class="md-select" on-change="updatePrimaryDisplay_"
+ aria-labelledby="displayScreenTitle"
value="[[getDisplaySelectMenuIndex_(
selectedDisplay, primaryDisplayId)]]">
<option value="0">$i18n{displayScreenPrimary}</option>
@@ -146,9 +149,12 @@
<template is="dom-if" if="[[!unifiedDesktopMode_]]" restamp>
<div class="settings-box embedded">
- <div class="start textarea">$i18n{displayOrientation}</div>
+ <div id="displayOrientation" class="start textarea">
+ $i18n{displayOrientation}
+ </div>
<div class="md-select-wrapper">
<select class="md-select" value="[[selectedDisplay.rotation]]"
+ aria-labelledby="displayOrientation"
on-change="onOrientationChange_">
<option value="0">$i18n{displayOrientationStandard}</option>
<option value="90">90</option>

Powered by Google App Engine
This is Rietveld 408576698