Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2809983002: Fix g_k_* symbols after blink rename. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
dglazkov, dcheng
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, emircan+watch+mediarecorder_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, fmalita+watch_chromium.org, haraken, iclelland, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, lunalu1, mac-reviews_chromium.org, mcasas+mediarecorder_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, Srirama, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix g_k_* symbols after blink rename. These were mosty renamed because these weren't actually const in most cases, so also make all these constants actually constant in addition to renaming them. No intended behavior change. BUG=675877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2809983002 Cr-Commit-Position: refs/heads/master@{#463712} Committed: https://chromium.googlesource.com/chromium/src/+/e6bb4131843342dbfede940f89a918cc29a399f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -109 lines) Patch
M third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElementSandbox.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/media/HTMLMediaElementControlsList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBufferTrackBaseSupplement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringViewTest.cpp View 17 chunks +67 lines, -69 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Nico
3 years, 8 months ago (2017-04-11 16:31:46 UTC) #5
dglazkov
lgtm
3 years, 8 months ago (2017-04-11 16:33:11 UTC) #7
dcheng
LGTM, thanks!
3 years, 8 months ago (2017-04-11 16:36:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809983002/1
3 years, 8 months ago (2017-04-11 16:40:54 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 19:10:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6bb4131843342dbfede940f89a9...

Powered by Google App Engine
This is Rietveld 408576698