Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextTest.cpp

Issue 2809983002: Fix g_k_* symbols after blink rename. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp b/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
index e6424f4db5c1a2f63dc8db8f005e6b6ff4c01d6e..1764204ba20ea68da8f5149bfe1ca60353596076 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTextTest.cpp
@@ -24,24 +24,24 @@ class LayoutTextTest : public RenderingTest {
}
};
-const char* g_k_taco_text = "Los Compadres Taco Truck";
+const char kTacoText[] = "Los Compadres Taco Truck";
} // namespace
TEST_F(LayoutTextTest, WidthZeroFromZeroLength) {
- SetBasicBody(g_k_taco_text);
+ SetBasicBody(kTacoText);
ASSERT_EQ(0, GetBasicText()->Width(0u, 0u, LayoutUnit(), TextDirection::kLtr,
false));
}
TEST_F(LayoutTextTest, WidthMaxFromZeroLength) {
- SetBasicBody(g_k_taco_text);
+ SetBasicBody(kTacoText);
ASSERT_EQ(0, GetBasicText()->Width(std::numeric_limits<unsigned>::max(), 0u,
LayoutUnit(), TextDirection::kLtr, false));
}
TEST_F(LayoutTextTest, WidthZeroFromMaxLength) {
- SetBasicBody(g_k_taco_text);
+ SetBasicBody(kTacoText);
float width = GetBasicText()->Width(0u, std::numeric_limits<unsigned>::max(),
LayoutUnit(), TextDirection::kLtr, false);
// Width may vary by platform and we just want to make sure it's something
@@ -51,7 +51,7 @@ TEST_F(LayoutTextTest, WidthZeroFromMaxLength) {
}
TEST_F(LayoutTextTest, WidthMaxFromMaxLength) {
- SetBasicBody(g_k_taco_text);
+ SetBasicBody(kTacoText);
ASSERT_EQ(0, GetBasicText()->Width(std::numeric_limits<unsigned>::max(),
std::numeric_limits<unsigned>::max(),
LayoutUnit(), TextDirection::kLtr, false));

Powered by Google App Engine
This is Rietveld 408576698