Implement sub source for WebGL2's clearBuffer*().

Implement sub source for WebGL2's clearBuffer*().

Conformance test is uploaded: https://github.com/KhronosGroup/WebGL/pull/2364

BUG=708730
TEST=conformance2/rendering/clearbuffer-sub-source.html
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809873003
Cr-Commit-Position: refs/heads/master@{#464246}
Committed: https://chromium.googlesource.com/chromium/src/+/67caee99605db7a1bde5ea88de2f8425672b0931

[Zhenyao Mo, 2017-04-11 22:53:55]

Description was changed from

==========
Implement sub source for WebGL2's clearBuffer*().

Conformance test is uploaded: https://github.com/KhronosGroup/WebGL/pull/2364

BUG=708730
TEST=conformance2/rendering/clearbuffer-sub-source.html
R=kbr@chromium.org,kainino@chromium.org
==========

to

==========
Implement sub source for WebGL2's clearBuffer*().

Conformance test is uploaded: https://github.com/KhronosGroup/WebGL/pull/2364

BUG=708730
TEST=conformance2/rendering/clearbuffer-sub-source.html
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2017-04-11 22:54:56]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2017-04-11 22:55:03]

PTAL

[commit-bot: I haz the power, 2017-04-11 22:56:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 23:00:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 23:00:29]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Zhenyao Mo, 2017-04-11 23:26:16]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 23:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 01:06:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 01:06:53]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-04-12 18:56:49]

LGTM with one change.

https://codereview.chromium.org/2809873003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/2809873003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:70: if
(!total.IsValid() || total.ValueOrDefault(0) > view->byteLength()) {
Here and throughout, I think we should continue to use ValueOrDie because it's
safer. If there's a code change which accidentally eliminates the IsValid()
check, ValueOrDie will prevent security bugs due to integer overflow.
ValueOrDefault runs the risk of not doing so.

[Zhenyao Mo, 2017-04-12 20:14:53]

https://codereview.chromium.org/2809873003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/2809873003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:70: if
(!total.IsValid() || total.ValueOrDefault(0) > view->byteLength()) {
On 2017/04/12 18:56:49, Ken Russell wrote:
> Here and throughout, I think we should continue to use ValueOrDie because it's
> safer. If there's a code change which accidentally eliminates the IsValid()
> check, ValueOrDie will prevent security bugs due to integer overflow.
> ValueOrDefault runs the risk of not doing so.

Done.

[Zhenyao Mo, 2017-04-12 20:14:58]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2017-04-12 20:15:22]

The CQ bit was unchecked by zmo@chromium.org

[Zhenyao Mo, 2017-04-12 20:15:27]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2017-04-12 20:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2809873003/#ps40001
(title: "address kbr's comment")

[commit-bot: I haz the power, 2017-04-12 20:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:30:01]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[Zhenyao Mo, 2017-04-12 22:46:27]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:47:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:12:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492037187006110,
"parent_rev": "9cc98580c28a6c26cddd7d1fbfeeeaf526ff9a15", "commit_rev":
"67caee99605db7a1bde5ea88de2f8425672b0931"}

[commit-bot: I haz the power, 2017-04-13 02:13:13]

Description was changed from

==========
Implement sub source for WebGL2's clearBuffer*().

Conformance test is uploaded: https://github.com/KhronosGroup/WebGL/pull/2364

BUG=708730
TEST=conformance2/rendering/clearbuffer-sub-source.html
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement sub source for WebGL2's clearBuffer*().

Conformance test is uploaded: https://github.com/KhronosGroup/WebGL/pull/2364

BUG=708730
TEST=conformance2/rendering/clearbuffer-sub-source.html
R=kbr@chromium.org,kainino@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2809873003
Cr-Commit-Position: refs/heads/master@{#464246}
Committed:
https://chromium.googlesource.com/chromium/src/+/67caee99605db7a1bde5ea88de2f...
==========

[commit-bot: I haz the power, 2017-04-13 02:13:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/67caee99605db7a1bde5ea88de2f...