Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Position.h

Issue 2809843002: Geolocation: rename Geoposition to Position to follow Spec (Closed)
Patch Set: position-string-expected.txt Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/Position.h
diff --git a/third_party/WebKit/Source/modules/geolocation/Geoposition.h b/third_party/WebKit/Source/modules/geolocation/Position.h
similarity index 83%
rename from third_party/WebKit/Source/modules/geolocation/Geoposition.h
rename to third_party/WebKit/Source/modules/geolocation/Position.h
index b1f2598f74d47c5e26cf5aee509763d018edac8b..06c2983181f47e5443353f14e4b4db52e8eafbe0 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geoposition.h
+++ b/third_party/WebKit/Source/modules/geolocation/Position.h
@@ -23,8 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef Geoposition_h
-#define Geoposition_h
+#ifndef Position_h
+#define Position_h
#include "bindings/core/v8/ScriptWrappable.h"
#include "modules/EventModules.h"
@@ -34,13 +34,13 @@
namespace blink {
-class Geoposition final : public GarbageCollected<Geoposition>,
- public ScriptWrappable {
+class Position final : public GarbageCollected<Position>,
+ public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static Geoposition* Create(Coordinates* coordinates, DOMTimeStamp timestamp) {
- return new Geoposition(coordinates, timestamp);
+ static Position* Create(Coordinates* coordinates, DOMTimeStamp timestamp) {
+ return new Position(coordinates, timestamp);
}
DEFINE_INLINE_TRACE() { visitor->Trace(coordinates_); }
@@ -49,7 +49,7 @@ class Geoposition final : public GarbageCollected<Geoposition>,
Coordinates* coords() const { return coordinates_; }
private:
- Geoposition(Coordinates* coordinates, DOMTimeStamp timestamp)
+ Position(Coordinates* coordinates, DOMTimeStamp timestamp)
: coordinates_(coordinates), timestamp_(timestamp) {
DCHECK(coordinates_);
}
@@ -60,4 +60,4 @@ class Geoposition final : public GarbageCollected<Geoposition>,
} // namespace blink
-#endif // Geoposition_h
+#endif // Position_h

Powered by Google App Engine
This is Rietveld 408576698