Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2809783004: Revert of Geolocation: rename Geoposition to Position to follow Spec (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, timvolodine, mvanouwerkerk+watch_chromium.org, mcasas+geolocation_chromium.org, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Geolocation: rename Geoposition to Position to follow Spec (patchset #4 id:80001 of https://codereview.chromium.org/2809843002/ ) Reason for revert: Seems like Position was already taken (by core\editing\position.h), reverting due to comment #29 I'm puzzled that this didn't trigger _any_ bot :? Original issue's description: > Geolocation: rename Geoposition to Position to follow Spec > > Renamed Geoposition to Position to align with the spec [1] and > rippled that change through the files. This change does not > surface to the Web platform since Geoposition is a > NoInterfaceObject _except_ for the way Geoposition is > stringified, which changes to "[object Position]". > > [1] https://www.w3.org/TR/geolocation-API/#position_interface > > BUG=708206 > > Review-Url: https://codereview.chromium.org/2809843002 > Cr-Commit-Position: refs/heads/master@{#463759} > Committed: https://chromium.googlesource.com/chromium/src/+/80d6493c57a368cf14c8c3eaf429732250df0e9e TBR=foolip@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708206 Review-Url: https://codereview.chromium.org/2809783004 Cr-Commit-Position: refs/heads/master@{#463797} Committed: https://chromium.googlesource.com/chromium/src/+/974b5ce01edf7431419fd59151581fcaa8397dfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -119 lines) Patch
M third_party/WebKit/LayoutTests/geolocation-api/position-string.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/geolocation-api/position-string-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/GeoNotifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/Geolocation.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/modules/geolocation/Geoposition.h View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/geolocation/Geoposition.idl View 1 chunk +31 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/modules/geolocation/Position.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/modules/geolocation/Position.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/PositionCallback.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/geolocation/PositionCallback.idl View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
mcasas
Created Revert of Geolocation: rename Geoposition to Position to follow Spec
3 years, 8 months ago (2017-04-11 21:54:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809783004/1
3 years, 8 months ago (2017-04-11 21:55:38 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 22:14:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/974b5ce01edf7431419fd5915158...

Powered by Google App Engine
This is Rietveld 408576698