Wait for compliance report to start ARC Kiosk app.

Wait for compliance report to start ARC Kiosk app.

This is partly rollback of http://crrev.com/2702313002
While content of policy compliance report is not important for
starting kiosk app, ChromeOS should wait for compliance report
from CloudDPC side to ensure that all permissions are already
correctly granted before app is started.

BUG=b/36678353
TEST=ArcPolicyBridge unittests

Review-Url: https://codereview.chromium.org/2809773004
Cr-Commit-Position: refs/heads/master@{#464384}
Committed: https://chromium.googlesource.com/chromium/src/+/699b308b719fd7a1065c05638ce4d635dc7b41ac

[Sergey Poromov, 2017-04-11 13:50:41]

poromov@chromium.org changed reviewers:
+ alexchau@chromium.org, battre@chromium.org, nkostylev@chromium.org,
wenzhang@chromium.org

[Sergey Poromov, 2017-04-11 13:50:42]

battre@chromium.org: Please review changes in 
chrome/browser/prefs/browser_prefs.cc

nkostylev@chromium.org, alexchau@chromium.org, wenzhang@chromium.org: Please
review changes in all other files

[Sergey Poromov, 2017-04-11 13:51:37]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 13:52:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 13:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 13:54:06]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Wen ZHANG, 2017-04-11 14:09:11]

lgtm from CloudDPC perspective

[Sergey Poromov, 2017-04-11 14:20:03]

The CQ bit was checked by poromov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 14:20:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 16:40:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 16:40:15]

Dry run: This issue passed the CQ dry run.

[Nikita (slow), 2017-04-12 15:06:21]

lgtm

https://codereview.chromium.org/2809773004/diff/20001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2809773004/diff/20001/chrome/common/pref_name...
chrome/common/pref_names.cc:39: // A preference that indicated whether Android
reported it's compliance status
nit: Should make a note that this one is used only for kiosk?

[Sergey Poromov, 2017-04-13 11:11:09]

https://codereview.chromium.org/2809773004/diff/20001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2809773004/diff/20001/chrome/common/pref_name...
chrome/common/pref_names.cc:39: // A preference that indicated whether Android
reported it's compliance status
On 2017/04/12 15:06:20, Nikita (slow) wrote:
> nit: Should make a note that this one is used only for kiosk?

Done.

[battre, 2017-04-13 11:54:05]

syntactically LGTM

I don't understand the meaning of this compliance and why it can only be set to
true and never to false. But I assume that the other reviewers take care of
that.

[Sergey Poromov, 2017-04-13 12:00:59]

The CQ bit was checked by poromov@chromium.org

[Sergey Poromov, 2017-04-13 12:01:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
wenzhang@chromium.org, nkostylev@chromium.org
Link to the patchset: https://codereview.chromium.org/2809773004/#ps40001
(title: "small comment update")

[commit-bot: I haz the power, 2017-04-13 12:01:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 12:45:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492084859777470,
"parent_rev": "46865bb32b95d0ce0f16e12c8a59bf30a6fd8da4", "commit_rev":
"699b308b719fd7a1065c05638ce4d635dc7b41ac"}

[commit-bot: I haz the power, 2017-04-13 12:46:19]

Description was changed from

==========
Wait for compliance report to start ARC Kiosk app.

This is partly rollback of http://crrev.com/2702313002
While content of policy compliance report is not important for
starting kiosk app, ChromeOS should wait for compliance report
from CloudDPC side to ensure that all permissions are already
correctly granted before app is started.

BUG=b/36678353
TEST=ArcPolicyBridge unittests
==========

to

==========
Wait for compliance report to start ARC Kiosk app.

This is partly rollback of http://crrev.com/2702313002
While content of policy compliance report is not important for
starting kiosk app, ChromeOS should wait for compliance report
from CloudDPC side to ensure that all permissions are already
correctly granted before app is started.

BUG=b/36678353
TEST=ArcPolicyBridge unittests

Review-Url: https://codereview.chromium.org/2809773004
Cr-Commit-Position: refs/heads/master@{#464384}
Committed:
https://chromium.googlesource.com/chromium/src/+/699b308b719fd7a1065c05638ce4...
==========

[commit-bot: I haz the power, 2017-04-13 12:46:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/699b308b719fd7a1065c05638ce4...