Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc

Issue 2809773004: Wait for compliance report to start ARC Kiosk app. (Closed)
Patch Set: small comment update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
diff --git a/chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc b/chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
index 19ab2ee65eb30b008673eb12ccc83e9484e18cef..d8639dbb704bd4255cc0c432da646f71ba0f696e 100644
--- a/chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
+++ b/chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
@@ -12,6 +12,7 @@
#include "chrome/browser/chromeos/arc/policy/arc_policy_bridge.h"
#include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
+#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/arc/arc_bridge_service.h"
@@ -143,8 +144,8 @@ class ArcPolicyBridgeTest : public testing::Test {
testing_profile_manager_ = base::MakeUnique<TestingProfileManager>(
TestingBrowserProcess::GetGlobal());
ASSERT_TRUE(testing_profile_manager_->SetUp());
- ASSERT_TRUE(
- testing_profile_manager_->CreateTestingProfile("user@gmail.com"));
+ profile_ = testing_profile_manager_->CreateTestingProfile("user@gmail.com");
+ ASSERT_TRUE(profile_);
}
protected:
@@ -152,6 +153,7 @@ class ArcPolicyBridgeTest : public testing::Test {
FakePolicyInstance* policy_instance() { return policy_instance_.get(); }
policy::PolicyMap& policy_map() { return policy_map_; }
base::RunLoop& run_loop() { return run_loop_; }
+ Profile* profile() { return profile_; }
private:
safe_json::TestingJsonParser::ScopedFactoryOverride factory_override_;
@@ -159,6 +161,7 @@ class ArcPolicyBridgeTest : public testing::Test {
std::unique_ptr<chromeos::ScopedUserManagerEnabler> user_manager_enabler_;
std::unique_ptr<TestingProfileManager> testing_profile_manager_;
base::RunLoop run_loop_;
+ TestingProfile* profile_;
std::unique_ptr<ArcBridgeService> bridge_service_;
std::unique_ptr<ArcPolicyBridge> policy_bridge_;
@@ -365,29 +368,43 @@ TEST_F(ArcPolicyBridgeTest, MultiplePoliciesTest) {
}
TEST_F(ArcPolicyBridgeTest, EmptyReportComplianceTest) {
+ ASSERT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
policy_bridge()->ReportCompliance(
"{}", PolicyComplianceCallback(run_loop().QuitClosure(),
kPolicyCompliantResponse));
run_loop().Run();
+ ASSERT_TRUE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
}
TEST_F(ArcPolicyBridgeTest, ParsableReportComplianceTest) {
+ ASSERT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
policy_bridge()->ReportCompliance(
"{\"nonComplianceDetails\" : []}",
PolicyComplianceCallback(run_loop().QuitClosure(),
kPolicyCompliantResponse));
run_loop().Run();
+ ASSERT_TRUE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
}
TEST_F(ArcPolicyBridgeTest, NonParsableReportComplianceTest) {
+ ASSERT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
policy_bridge()->ReportCompliance(
"\"nonComplianceDetails\" : [}",
PolicyComplianceCallback(run_loop().QuitClosure(),
kPolicyCompliantResponse));
run_loop().Run();
+ ASSERT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
}
TEST_F(ArcPolicyBridgeTest, ReportComplianceTest_WithNonCompliantDetails) {
+ ASSERT_FALSE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
policy_bridge()->ReportCompliance(
"{\"nonComplianceDetails\" : "
"[{\"fieldPath\":\"\",\"nonComplianceReason\":0,\"packageName\":\"\","
@@ -395,6 +412,8 @@ TEST_F(ArcPolicyBridgeTest, ReportComplianceTest_WithNonCompliantDetails) {
PolicyComplianceCallback(run_loop().QuitClosure(),
kPolicyCompliantResponse));
run_loop().Run();
+ ASSERT_TRUE(
+ profile()->GetPrefs()->GetBoolean(prefs::kArcPolicyComplianceReported));
}
// This and the following test send the policies through a mojo connection
« no previous file with comments | « chrome/browser/chromeos/arc/policy/arc_policy_bridge.cc ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698