test/v8heapconst/v8heapconst.status - Issue 2809653003: Introduce mkgrokdump to update tools/v8heapconst.py.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/v8heapconst/v8heapconst.status

Issue 2809653003: Introduce mkgrokdump to update tools/v8heapconst.py. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 the V8 project authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 [

	6 # Only test for default mode x64.

	7 ['variant != default', {
	Michael Achenbach 2017/04/11 09:45:54 nit: You could write it in one line: variant != de nit: You could write it in one line: variant != default or arch != x64 Yang 2017/04/11 09:57:20 Done. Show quoted text On 2017/04/11 09:45:54, Michael Achenbach wrote: > nit: You could write it in one line: > variant != default or arch != x64 Done.
	8 '*': [SKIP],

	9 }], # variant != default

	10 ['arch != x64', {

	11 '*': [SKIP],

	12 }], # variant != default

	13 ]

OLD	NEW