Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2809353002: Show more detailed error info of navigation preload in DevTools Network tab (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 8 months ago
Reviewers:
falken, dgozman, pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Show more detailed error info of navigation preload in DevTools Network tab See https://crbug.com/710738 for the screen images. BUG=710738 Review-Url: https://codereview.chromium.org/2809353002 Cr-Commit-Position: refs/heads/master@{#464599} Committed: https://chromium.googlesource.com/chromium/src/+/ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3

Patch Set 1 #

Patch Set 2 : update service-workers-navigation-preload-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M content/browser/devtools/protocol/network_handler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
horo
falken@ Could you please review this?
3 years, 8 months ago (2017-04-12 04:11:15 UTC) #4
falken
great lgtm
3 years, 8 months ago (2017-04-12 04:27:06 UTC) #5
horo
pfeldman@ Could you please review this?
3 years, 8 months ago (2017-04-12 04:51:44 UTC) #9
horo
dgozman@ Cold you please review this CL? Thank you.
3 years, 8 months ago (2017-04-13 15:54:15 UTC) #13
dgozman
lgtm
3 years, 8 months ago (2017-04-13 17:20:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809353002/20001
3 years, 8 months ago (2017-04-13 21:47:57 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 23:16:39 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec2f0c7a07f26bb15dbf42c94153...

Powered by Google App Engine
This is Rietveld 408576698