Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: content/browser/devtools/protocol/network_handler.cc

Issue 2809353002: Show more detailed error info of navigation preload in DevTools Network tab (Closed)
Patch Set: update service-workers-navigation-preload-expected.txt Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/network_handler.cc
diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc
index 94eb1e885da45e309bd26f0b0c398e0f28774597..700f10f38b400d42a1d96afc63b03c03970f21d7 100644
--- a/content/browser/devtools/protocol/network_handler.cc
+++ b/content/browser/devtools/protocol/network_handler.cc
@@ -696,9 +696,11 @@ void NetworkHandler::NavigationPreloadCompleted(
return;
if (completion_status.error_code != net::OK) {
frontend_->LoadingFailed(
- request_id, base::TimeTicks::Now().ToInternalValue() /
- static_cast<double>(base::Time::kMicrosecondsPerSecond),
- Page::ResourceTypeEnum::Other, "Navigation Preload Error",
+ request_id,
+ base::TimeTicks::Now().ToInternalValue() /
+ static_cast<double>(base::Time::kMicrosecondsPerSecond),
+ Page::ResourceTypeEnum::Other,
+ net::ErrorToString(completion_status.error_code),
completion_status.error_code == net::Error::ERR_ABORTED);
}
frontend_->LoadingFinished(
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698