Split ToV8.h

Split ToV8.h

Most of ToV8 can be moved to platform/bindings, except for a few core-specific overloads. ScriptValue uses ToV8 and defines ScriptValue::From inside ToV8.h because of a cyclic dependency. So moving ToV8.h to platform also allows ScriptValue to be moved.

All the core specific overloads are moved to ToV8ForCore.h/cpp and the rest are kept in ToV8.h (which will be moved to platform/bindings later).

BUG=682322
Review-Url: https://codereview.chromium.org/2809243002
Cr-Commit-Position: refs/heads/master@{#464280}
Committed: https://chromium.googlesource.com/chromium/src/+/fec2c059777516677c2ed1eaf9d906340ca273f5

[adithyas, 2017-04-11 20:26:40]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 20:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adithyas, 2017-04-11 21:57:59]

adithyas@chromium.org changed reviewers:
+ jbroman@chromium.org

[commit-bot: I haz the power, 2017-04-11 22:40:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 22:40:37]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-04-12 02:45:10]

Can we instead rename ToV8.h to ToV8ForCore.h?

c.f., We already have ToV8ForModules.h.

[haraken, 2017-04-12 02:45:20]

On 2017/04/12 02:45:10, haraken wrote:
> Can we instead rename ToV8.h to ToV8ForCore.h?
> 
> c.f., We already have ToV8ForModules.h.

With that change, LGTM.

[Yuki Shiino, 2017-04-12 08:16:11]

yukishiino@google.com changed reviewers:
+ yukishiino@google.com

[Yuki Shiino, 2017-04-12 08:16:12]

LGTM.

Just a question, when are we going to make a new directory platform/bindings/?

If we could put ToV8ForPlatform.h in platform/bindings/ from the beginning, we
don't need to rewrite the directory part of #include directives.  Having
ToV8ForPlatform.h in bindings/core/ looks a bit weird.

To me, some of files already look ready to move to platform/bindings/, so I'm
just wondering.

[jbroman, 2017-04-12 14:32:20]

jbroman@chromium.org changed reviewers:
+ haraken@chromium.org

[jbroman, 2017-04-12 14:32:21]

lgtm

[adithyas, 2017-04-12 16:00:11]

Description was changed from

==========
Split ToV8.h

Most of ToV8 can be moved to platform/bindings, except for a few core-specific
overloads. ScriptValue uses ToV8 and defines ScriptValue::From inside ToV8.h
because of a cyclic dependency. So moving ToV8.h to platform also allows
ScriptValue to be moved.

All the core specific overloads are kept inside ToV8.h and the rest are moved to
ToV8ForPlatform.h (which will be moved to platform/bindings later).

BUG=682322
==========

to

==========
Split ToV8.h

Most of ToV8 can be moved to platform/bindings, except for a few core-specific
overloads. ScriptValue uses ToV8 and defines ScriptValue::From inside ToV8.h
because of a cyclic dependency. So moving ToV8.h to platform also allows
ScriptValue to be moved.

All the core specific overloads are moved to ToV8ForCore.h/cpp and the rest are
kept in ToV8.h (which will be moved to platform/bindings later).

BUG=682322
==========

[adithyas, 2017-04-12 17:03:33]

Renamed ToV8 to ToV8ForCore, and ToV8ForPlatform.h to ToV8.h

I will probably be creating a platform/bindings directory soon. The reason I
haven't already is that a lot of files that are moving are interdependent and
for even one of them to move, all the others need to already be in
platform/bindings as well. There are still a couple of files with core
dependencies that I need to clean up, which will unblock the other files as
well.

[adithyas, 2017-04-12 22:16:20]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2017-04-12 22:16:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@google.com, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2809243002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-12 22:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:37:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492035380713720,
"parent_rev": "10603e265ae3928a1d9ea44470d82976d001bd3b", "commit_rev":
"4027ba81115d7c1bb21a1aa048268ef289caccde"}

[commit-bot: I haz the power, 2017-04-13 03:42:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492035380713720,
"parent_rev": "07955d420101ad98b446a9b1b3d26426627803cf", "commit_rev":
"fec2c059777516677c2ed1eaf9d906340ca273f5"}

[commit-bot: I haz the power, 2017-04-13 03:43:49]

Description was changed from

==========
Split ToV8.h

Most of ToV8 can be moved to platform/bindings, except for a few core-specific
overloads. ScriptValue uses ToV8 and defines ScriptValue::From inside ToV8.h
because of a cyclic dependency. So moving ToV8.h to platform also allows
ScriptValue to be moved.

All the core specific overloads are moved to ToV8ForCore.h/cpp and the rest are
kept in ToV8.h (which will be moved to platform/bindings later).

BUG=682322
==========

to

==========
Split ToV8.h

Most of ToV8 can be moved to platform/bindings, except for a few core-specific
overloads. ScriptValue uses ToV8 and defines ScriptValue::From inside ToV8.h
because of a cyclic dependency. So moving ToV8.h to platform also allows
ScriptValue to be moved.

All the core specific overloads are moved to ToV8ForCore.h/cpp and the rest are
kept in ToV8.h (which will be moved to platform/bindings later).

BUG=682322

Review-Url: https://codereview.chromium.org/2809243002
Cr-Commit-Position: refs/heads/master@{#464280}
Committed:
https://chromium.googlesource.com/chromium/src/+/fec2c059777516677c2ed1eaf9d9...
==========

[commit-bot: I haz the power, 2017-04-13 03:43:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fec2c059777516677c2ed1eaf9d9...