[autofill] Expand Autofill.Quality.* to log false positives/true negatives.

[autofill] Expand Autofill.Quality.* to log false positives/true negatives.

This CL adds Autofill.Quality.* logging for the following cases:

 * the field was not confirmed as autofillable (either the user
   left the field empty or filled the field with data that was
   not recognized); and,

   - A: the field was predicated as autofillable
        (false positive)
   - B: the field was not predicted as autofillable
        (true negative)

These round out the logging required to compute precision, recall and
other performance metrics as defined at
https://en.wikipedia.org/wiki/Precision_and_recall.

BUG=710474
Review-Url: https://codereview.chromium.org/2809213002
Cr-Commit-Position: refs/heads/master@{#464127}
Committed: https://chromium.googlesource.com/chromium/src/+/8f71139f8c5982d83fcdcc840a5275698b71438c

[Roger McFarlane (Chromium), 2017-04-11 17:19:41]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 17:20:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2017-04-11 17:23:10]

rogerm@chromium.org changed reviewers:
+ jwd@chromium.org, mathp@chromium.org

[Roger McFarlane (Chromium), 2017-04-11 17:23:10]

PTAL?

[commit-bot: I haz the power, 2017-04-11 17:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 17:51:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Roger McFarlane (Chromium), 2017-04-11 17:55:16]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 17:56:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2017-04-11 17:56:13]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-11 18:34:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 18:34:50]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Roger McFarlane (Chromium), 2017-04-11 18:54:19]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 18:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-11 20:18:40]

The code is very neat but the test is getting a bit large. I'll let you decide
how/when to address it. lgtm

https://codereview.chromium.org/2809213002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics.h (right):

https://codereview.chromium.org/2809213002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.h:280: // The field was left
empty and autofil predicted that the field type would
*Autofill

https://codereview.chromium.org/2809213002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.h:284: // user's profile (it's
type could not be determined). Autofill predicted
*its

https://codereview.chromium.org/2809213002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.h:291: // user's profile (it's
type could not be determined). Autofill predicted
*its

https://codereview.chromium.org/2809213002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/2809213002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:563:
AutofillMetrics::TYPE_MISMATCH_EMPTY, 1);
it's a little bit unfortunate how this test is constructed and does all
expectations in one scope. If TYPE_MISMATCH_EMPTY and TYPE_MISMATCH_UNKNOWN were
switched in the feature code, for example, this test wouldn't catch it. 

Perhaps we can make a tighter scope for each expectation because this is getting
a little bit out of hand.

[jwd, 2017-04-11 21:16:18]

lgtm

[commit-bot: I haz the power, 2017-04-11 21:21:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 21:21:47]

Dry run: This issue passed the CQ dry run.

[Roger McFarlane (Chromium), 2017-04-12 15:50:19]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 15:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2017-04-12 16:51:28]

The CQ bit was checked by rogerm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 16:51:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Roger McFarlane (Chromium), 2017-04-12 16:52:19]

Patchset #3 (id:60001) has been deleted

[Roger McFarlane (Chromium), 2017-04-12 16:54:03]

thanks.

mathp@... extracted the unittests for better isolation

another look?

[Mathieu, 2017-04-12 16:59:45]

thanks, lgtm

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:551: const
ServerFieldType field_type;
nit: field_type -> actual_field_type?

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:609: // Validate
the histogram counte values.
*count

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:653:
UnrecognizedOrEmptyFieldsCase{EMPTY_TYPE, false,
nit: /*make_prediction=*/false

[Roger McFarlane (Chromium), 2017-04-12 17:10:51]

Thanks.

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:551: const
ServerFieldType field_type;
On 2017/04/12 16:59:45, Mathieu wrote:
> nit: field_type -> actual_field_type?

Done.

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:609: // Validate
the histogram counte values.
On 2017/04/12 16:59:45, Mathieu wrote:
> *count

Done.

https://codereview.chromium.org/2809213002/diff/80001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics_unittest.cc:653:
UnrecognizedOrEmptyFieldsCase{EMPTY_TYPE, false,
On 2017/04/12 16:59:45, Mathieu wrote:
> nit: /*make_prediction=*/false

Done.

[Roger McFarlane (Chromium), 2017-04-12 17:10:58]

The CQ bit was checked by rogerm@chromium.org

[Roger McFarlane (Chromium), 2017-04-12 17:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2809213002/#ps80002
(title: "fix nits")

[commit-bot: I haz the power, 2017-04-12 17:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:09:43]

CQ is committing da patch.

Bot data: {"patchset_id": 80002, "attempt_start_ts": 1492017058200930,
"parent_rev": "dda3a2b272de6426c2d1da121731d8acd016569f", "commit_rev":
"8f71139f8c5982d83fcdcc840a5275698b71438c"}

[commit-bot: I haz the power, 2017-04-12 20:10:45]

Description was changed from

==========
[autofill] Expand Autofill.Quality.* to log false positives/true negatives.

This CL adds Autofill.Quality.* logging for the following cases:

 * the field was not confirmed as autofillable (either the user
   left the field empty or filled the field with data that was
   not recognized); and,

   - A: the field was predicated as autofillable
        (false positive)
   - B: the field was not predicted as autofillable
        (true negative)

These round out the logging required to compute precision, recall and
other performance metrics as defined at
https://en.wikipedia.org/wiki/Precision_and_recall.

BUG=710474
==========

to

==========
[autofill] Expand Autofill.Quality.* to log false positives/true negatives.

This CL adds Autofill.Quality.* logging for the following cases:

 * the field was not confirmed as autofillable (either the user
   left the field empty or filled the field with data that was
   not recognized); and,

   - A: the field was predicated as autofillable
        (false positive)
   - B: the field was not predicted as autofillable
        (true negative)

These round out the logging required to compute precision, recall and
other performance metrics as defined at
https://en.wikipedia.org/wiki/Precision_and_recall.

BUG=710474

Review-Url: https://codereview.chromium.org/2809213002
Cr-Commit-Position: refs/heads/master@{#464127}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f71139f8c5982d83fcdcc840a52...
==========

[commit-bot: I haz the power, 2017-04-12 20:10:46]

Committed patchset #4 (id:80002) as
https://chromium.googlesource.com/chromium/src/+/8f71139f8c5982d83fcdcc840a52...