Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3127)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2809213002: [autofill] Expand Autofill.Quality.* to log false positives/true negatives. (Closed)
Patch Set: fix nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 15ee9a173c9debb9119f586cc6c5ce5773b62a2e..33d89c6bcbb733142e3ac59908fb0f26b739cd62 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -262,6 +262,7 @@ class AutofillMetrics {
SAVE_CARD_PROMPT_DISMISS_CLICK_LEARN_MORE,
// The prompt was dismissed because the user clicked a legal message link.
SAVE_CARD_PROMPT_DISMISS_CLICK_LEGAL_MESSAGE,
+
NUM_SAVE_CARD_PROMPT_METRICS,
};
@@ -270,9 +271,27 @@ class AutofillMetrics {
// the heuristic prediction, for the crowd-sourced prediction, and for the
// overall prediction.
enum FieldTypeQualityMetric {
- TYPE_UNKNOWN = 0, // Offered no prediction.
- TYPE_MATCH, // Predicted correctly.
- TYPE_MISMATCH, // Predicted incorrectly.
+ // The field was found to be of type T, but autofill made no prediction.
+ TYPE_UNKNOWN = 0,
+ // The field was found to be of type T, which matches the predicted type.
+ TYPE_MATCH,
+ // The field was found to be of type T, autofill predicted some other type.
+ TYPE_MISMATCH,
+ // The field was left empty and autofil predicted that the field type would
+ // be UNKNOWN.
+ TYPE_MATCH_EMPTY,
+ // The field was populated with data that did not match any part of the
+ // user's profile (it's type could not be determined). Autofill predicted
+ // the field's type would be UNKNOWN.
+ TYPE_MATCH_UNKNOWN,
+ // The field was left empty, autofill predicted the user would populate it
+ // with autofillable data.
+ TYPE_MISMATCH_EMPTY,
+ // The field was populated with data that did not match any part of the
+ // user's profile (it's type could not be determined). Autofill predicted
+ // the user would populate it with autofillable data.
+ TYPE_MISMATCH_UNKNOWN,
+ // This must be the last value.
NUM_FIELD_TYPE_QUALITY_METRICS,
};
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_metrics_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698