Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2809183003:
[wrapper-tracing] Fix node list leak (Closed)
|
Created:
3 years, 8 months ago by Michael Lippautz Modified:
3 years, 8 months ago CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[wrapper-tracing] Fix node list leak
Only trace node lists that hang of live nodes.
BUG=chromium:707544
Review-Url: https://codereview.chromium.org/2809183003
Cr-Commit-Position: refs/heads/master@{#463986}
Committed: https://chromium.googlesource.com/chromium/src/+/76798dbd04a30a8e1acdf71ecab93d09dac4ec5b
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed comments. #
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mlippautz@chromium.org changed reviewers: + haraken@chromium.org, keishi@chromium.org
ptal I think we should only trace the lists hanging of live nodes (and their NodeListsNodeData).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Looks good. I think wrapper tracing WeakMembers is bad but in this case it makes sense. The references from NodeListsNodeData needs to stay weak in case it doesn't have a wrapper.
LGTM
sigbjornf@opera.com changed reviewers: + sigbjornf@opera.com
lgtm https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Document.cpp (left): https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Document.cpp:6636: visitor->TraceWrappers(style_engine_); Add a comment saying why/where node_lists_ are taken care of instead? https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp (right): https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp:58: for (NodeListAtomicNameCacheMap::const_iterator it = Nit: ranged for loops possible?
Thanks a lot everyone! https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Document.cpp (left): https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Document.cpp:6636: visitor->TraceWrappers(style_engine_); On 2017/04/12 06:51:50, sof wrote: > Add a comment saying why/where node_lists_ are taken care of instead? Done. https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp (right): https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp:58: for (NodeListAtomicNameCacheMap::const_iterator it = On 2017/04/12 06:51:50, sof wrote: > Nit: ranged for loops possible? Sure, just used a similar loop that is also present in the .h file. Fixed to use range loop.
Thanks a lot everyone! https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/Document.cpp (left): https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/Document.cpp:6636: visitor->TraceWrappers(style_engine_); On 2017/04/12 06:51:50, sof wrote: > Add a comment saying why/where node_lists_ are taken care of instead? Done. https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp (right): https://codereview.chromium.org/2809183003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/dom/NodeListsNodeData.cpp:58: for (NodeListAtomicNameCacheMap::const_iterator it = On 2017/04/12 06:51:50, sof wrote: > Nit: ranged for loops possible? Sure, just used a similar loop that is also present in the .h file. Fixed to use range loop.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, sigbjornf@opera.com Link to the patchset: https://codereview.chromium.org/2809183003/#ps20001 (title: "Addressed comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491990197230180,
"parent_rev": "00f34dff72890b172b5026756453dd31f817a9b9", "commit_rev":
"76798dbd04a30a8e1acdf71ecab93d09dac4ec5b"}
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] Fix node list leak Only trace node lists that hang of live nodes. BUG=chromium:707544 ========== to ========== [wrapper-tracing] Fix node list leak Only trace node lists that hang of live nodes. BUG=chromium:707544 Review-Url: https://codereview.chromium.org/2809183003 Cr-Commit-Position: refs/heads/master@{#463986} Committed: https://chromium.googlesource.com/chromium/src/+/76798dbd04a30a8e1acdf71ecab9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/76798dbd04a30a8e1acdf71ecab9... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
