[wrapper-tracing] Fix node list leak

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 6615 matching lines @@
   for (int i = static_cast<int>(would_load_reason_) + 1;
        i <= static_cast<int>(reason); ++i)
     RecordLoadReasonToHistogram(static_cast<WouldLoadReason>(i));
   would_load_reason_ = reason;
 }
 
 DEFINE_TRACE_WRAPPERS(Document) {
   visitor->TraceWrappers(imports_controller_);
   visitor->TraceWrappers(implementation_);
   visitor->TraceWrappers(style_sheet_list_);
   visitor->TraceWrappers(style_engine_);

[sof, 2017/04/12 06:51:50]

Add a comment saying why/where node_lists_ are taken care of instead?

[Michael Lippautz, 2017/04/12 08:06:33]

Done.

-  for (int i = 0; i < kNumNodeListInvalidationTypes; ++i) {
-    for (auto list : node_lists_[i]) {
-      if (IsHTMLCollectionType(list->GetType())) {
-        visitor->TraceWrappersWithManualWriteBarrier(
-            static_cast<const HTMLCollection*>(list.Get()));
-      } else {
-        visitor->TraceWrappersWithManualWriteBarrier(
-            static_cast<const LiveNodeList*>(list.Get()));
-      }
-    }
-  }
   // Cannot trace in Supplementable<Document> as it is part of platform/ and
   // thus cannot refer to ScriptWrappableVisitor.
   visitor->TraceWrappers(
       static_cast<FontFaceSet*>(Supplementable<Document>::supplements_.at(
           FontFaceSet::SupplementName())));
   ContainerNode::TraceWrappers(visitor);
 }
 
 template class CORE_TEMPLATE_EXPORT Supplement<Document>;
 
 }  // namespace blink
 
 #ifndef NDEBUG
 static WeakDocumentSet& liveDocumentSet() {
   DEFINE_STATIC_LOCAL(WeakDocumentSet, set, ());
   return set;
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->Url().GetString().Utf8().Data());
 }
 #endif