Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2809093002: Revert of PPC/s390: [ignition] Add call bytecodes for undefined receiver (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of PPC/s390: [ignition] Add call bytecodes for undefined receiver (patchset #1 id:1 of https://codereview.chromium.org/2809743003/ ) Reason for revert: Need to revert: https://chromium-review.googlesource.com/c/463287/ Original issue's description: > PPC/s390: [ignition] Add call bytecodes for undefined receiver > > Port 751e89359123df4f6e5f0b28b89fcdf63ed16a77 > > Original Commit Message: > > Adds a collection of call bytecodes which have an implicit undefined > receiver argument, for cases such as global calls where we know that the > receiver has to be undefined. This way we can skip an LdaUndefined, > decrease bytecode register pressure, and set a more accurate > ConvertReceiverMode on the interpreter and TurboFan call. > > As a side effect, the "normal" Call bytecode now becomes a rare case > (only with calls and super property calls), so we get rid of its 0-2 > argument special cases and modify CallProperty[N] to use the > NotNullOrUndefined ConvertReceiverMode. > > R=leszeks@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com > BUG= > LOG=N > > Review-Url: https://codereview.chromium.org/2809743003 > Cr-Commit-Position: refs/heads/master@{#44539} > Committed: https://chromium.googlesource.com/v8/v8/+/41b228057f89e73fbaae867177d523e60d4e92bc TBR=joransiu@ca.ibm.com,jyan@ca.ibm.com,leszeks@chromium.org,michael_dawson@ca.ibm.com,bjaideep@ca.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2809093002 Cr-Commit-Position: refs/heads/master@{#44546} Committed: https://chromium.googlesource.com/v8/v8/+/f7b61ca6dc8376712ac1dea75c74cb2d2271e992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -39 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 5 chunks +11 lines, -20 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 5 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of PPC/s390: [ignition] Add call bytecodes for undefined receiver
3 years, 8 months ago (2017-04-11 06:43:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809093002/1
3 years, 8 months ago (2017-04-11 06:43:19 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 06:43:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f7b61ca6dc8376712ac1dea75c74cb2d227...

Powered by Google App Engine
This is Rietveld 408576698