Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2809743003: PPC/s390: [ignition] Add call bytecodes for undefined receiver (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [ignition] Add call bytecodes for undefined receiver Port 751e89359123df4f6e5f0b28b89fcdf63ed16a77 Original Commit Message: Adds a collection of call bytecodes which have an implicit undefined receiver argument, for cases such as global calls where we know that the receiver has to be undefined. This way we can skip an LdaUndefined, decrease bytecode register pressure, and set a more accurate ConvertReceiverMode on the interpreter and TurboFan call. As a side effect, the "normal" Call bytecode now becomes a rare case (only with calls and super property calls), so we get rid of its 0-2 argument special cases and modify CallProperty[N] to use the NotNullOrUndefined ConvertReceiverMode. R=leszeks@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2809743003 Cr-Commit-Position: refs/heads/master@{#44539} Committed: https://chromium.googlesource.com/v8/v8/+/41b228057f89e73fbaae867177d523e60d4e92bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 5 chunks +20 lines, -11 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 5 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 8 months ago (2017-04-10 20:21:19 UTC) #1
john.yan
lgtm
3 years, 8 months ago (2017-04-10 20:32:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809743003/1
3 years, 8 months ago (2017-04-10 20:32:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/41b228057f89e73fbaae867177d523e60d4e92bc
3 years, 8 months ago (2017-04-10 20:57:32 UTC) #7
Michael Achenbach
3 years, 8 months ago (2017-04-11 06:43:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2809093002/ by machenbach@chromium.org.

The reason for reverting is: Need to revert:
https://chromium-review.googlesource.com/c/463287/.

Powered by Google App Engine
This is Rietveld 408576698