Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2808953002: Revert of Followup comments from r460581. (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
nasko, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Followup comments from r460581. (patchset #1 id:1 of https://codereview.chromium.org/2781383002/ ) Reason for revert: Exposed races with FrameHostMsg_DidStopLoading BUG=710062 Original issue's description: > Followup comments from r460581. > > BUG=365039, 705559 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2781383002 > Cr-Commit-Position: refs/heads/master@{#461012} > Committed: https://chromium.googlesource.com/chromium/src/+/8393de464114cb0a3d5e82a93a491728aa49e043 TBR=nasko@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=365039, 705559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2808953002 Cr-Commit-Position: refs/heads/master@{#463399} Committed: https://chromium.googlesource.com/chromium/src/+/1d0058ca68075ed731ef2d3c150b9c3aba1534f6

Patch Set 1 #

Patch Set 2 : manual merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M content/browser/browser_side_navigation_browsertest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 1 chunk +17 lines, -13 lines 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
D content/test/data/page_with_empty_beforeunload.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jam
Created Revert of Followup comments from r460581.
3 years, 8 months ago (2017-04-10 18:30:00 UTC) #2
dcheng
LGTM
3 years, 8 months ago (2017-04-10 18:30:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808953002/1
3 years, 8 months ago (2017-04-10 18:31:12 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/244650) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 18:36:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808953002/190001
3 years, 8 months ago (2017-04-10 19:31:20 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:29:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:190001) as
https://chromium.googlesource.com/chromium/src/+/1d0058ca68075ed731ef2d3c150b...

Powered by Google App Engine
This is Rietveld 408576698