Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2781383002: Followup comments from r460581. (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
nasko, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, blink-reviews, blink-reviews-frames_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Followup comments from r460581. BUG=365039, 705559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2781383002 Cr-Commit-Position: refs/heads/master@{#461012} Committed: https://chromium.googlesource.com/chromium/src/+/8393de464114cb0a3d5e82a93a491728aa49e043

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M content/browser/browser_side_navigation_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +13 lines, -17 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A content/test/data/page_with_empty_beforeunload.html View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (9 generated)
jam
3 years, 8 months ago (2017-03-30 14:52:59 UTC) #3
dcheng
Blink LGTM https://codereview.chromium.org/2781383002/diff/1/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/2781383002/diff/1/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp#newcode1431 third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:1431: // process. Nit: move this to line ...
3 years, 8 months ago (2017-03-30 19:16:57 UTC) #8
nasko
content/ LGTM
3 years, 8 months ago (2017-03-30 22:49:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781383002/1
3 years, 8 months ago (2017-03-31 03:23:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8393de464114cb0a3d5e82a93a491728aa49e043
3 years, 8 months ago (2017-03-31 03:30:22 UTC) #14
jam
3 years, 8 months ago (2017-04-10 18:29:59 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2808953002/ by jam@chromium.org.

The reason for reverting is: Exposed races with FrameHostMsg_DidStopLoading

BUG=710062.

Powered by Google App Engine
This is Rietveld 408576698