Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2808573002: PaymentRequest: Change the timer task type. (Closed)

Created:
3 years, 8 months ago by zino
Modified:
3 years, 8 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, gogerald+paymentswatch_chromium.org, blink-reviews, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentRequest: Change the timer task type. Moved the timer task from per-renderer to per-frame in the following CL. https://codereview.chromium.org/2640293002/ At that time, the spec didn't mention it properly but it has become clear recently. The spec says that we should use UserInteraction task source. Related spec change: https://github.com/w3c/browser-payment-api/pull/405 BUG=none Review-Url: https://codereview.chromium.org/2808573002 Cr-Commit-Position: refs/heads/master@{#463353} Committed: https://chromium.googlesource.com/chromium/src/+/85be9792615f94cd01c32c7232314e969ff03880

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
zino
PTAL
3 years, 8 months ago (2017-04-10 14:56:36 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-04-10 15:17:18 UTC) #4
please use gerrit instead
https://codereview.chromium.org/2808573002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2808573002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode857 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:857: m_completeTimer(TaskRunnerHelper::get(TaskType::UserInteraction, frame()), Please don't change this line. According to ...
3 years, 8 months ago (2017-04-10 15:35:06 UTC) #5
zino
https://codereview.chromium.org/2808573002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2808573002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode857 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:857: m_completeTimer(TaskRunnerHelper::get(TaskType::UserInteraction, frame()), On 2017/04/10 15:35:06, ಠ_ಠ wrote: > Please ...
3 years, 8 months ago (2017-04-10 16:11:12 UTC) #6
please use gerrit instead
https://codereview.chromium.org/2808573002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (right): https://codereview.chromium.org/2808573002/diff/1/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp#newcode857 third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:857: m_completeTimer(TaskRunnerHelper::get(TaskType::UserInteraction, frame()), On 2017/04/10 16:11:12, zino wrote: > On ...
3 years, 8 months ago (2017-04-10 16:12:52 UTC) #7
please use gerrit instead
I've filed https://github.com/w3c/browser-payment-api/issues/508 to define the algorithm for `.complete()` timeout in the spec. That should ...
3 years, 8 months ago (2017-04-10 16:18:02 UTC) #8
zino
On 2017/04/10 16:18:02, ಠ_ಠ wrote: > I've filed https://github.com/w3c/browser-payment-api/issues/508 to define the > algorithm for ...
3 years, 8 months ago (2017-04-10 17:20:27 UTC) #9
please use gerrit instead
lgtm
3 years, 8 months ago (2017-04-10 17:21:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808573002/20001
3 years, 8 months ago (2017-04-10 17:28:01 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:17:39 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/85be9792615f94cd01c32c723231...

Powered by Google App Engine
This is Rietveld 408576698