PaymentRequest: Change the timer task type.

third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequest.h"
 
 #include <stddef.h>
 #include <utility>
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 836 matching lines @@
 }
 
 PaymentRequest::PaymentRequest(ExecutionContext* executionContext,
                                const HeapVector<PaymentMethodData>& methodData,
                                const PaymentDetailsInit& details,
                                const PaymentOptions& options,
                                ExceptionState& exceptionState)
     : ContextLifecycleObserver(executionContext),
       m_options(options),
       m_clientBinding(this),
-      m_completeTimer(TaskRunnerHelper::get(TaskType::MiscPlatformAPI, frame()),
+      m_completeTimer(TaskRunnerHelper::get(TaskType::UserInteraction, frame()),

[please use gerrit instead, 2017/04/10 15:35:06]

Please don't change this line.

According to the spec, user interaction timers should be used only for
'shippingaddresschange' and 'shippingoptionchange' methods. These two timers are
in PaymentRequestUpdateEvent.abort_timer_. So you're good there.

There's some language about queueing a task in user interaction task source for
.abort() method, but there's no delay specified in there. Because Chromium's
implementation of .abort() is asynchronous, we don't need a timer. 

[zino, 2017/04/10 16:11:12]

I was confused here: User accepts the payment request algorithm
https://w3c.github.io/browser-payment-api/#user-accepts-the-payment-request-a...
https://w3c.github.io/browser-payment-api/#complete-method

But my thought was incorrect according to your explaination.
After show() has been resolved, if we do not call complete(), then user
interface is blocked.
So, it's used for causing timeout if the page never calls complete().

Then, do we have to change it to kTimer vs kUnspecedTimer? WDYT?

[please use gerrit instead, 2017/04/10 16:12:52]

We cannot keep MiscPlatformAPI task type?

                       this,
                       &PaymentRequest::onCompleteTimeout) {
   Vector<payments::mojom::blink::PaymentMethodDataPtr> validatedMethodData;
   validateAndConvertPaymentMethodData(methodData, validatedMethodData,
                                       *getExecutionContext(), exceptionState);
   if (exceptionState.hadException())
     return;
 
   if (!getExecutionContext()->isSecureContext()) {
     exceptionState.throwSecurityError("Must be in a secure context");
@@ skipping 204 matching lines @@
   m_completeResolver.clear();
   m_showResolver.clear();
   m_abortResolver.clear();
   m_canMakePaymentResolver.clear();
   if (m_clientBinding.is_bound())
     m_clientBinding.Close();
   m_paymentProvider.reset();
 }
 
 }  // namespace blink