Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2808403002: [wasm] Bumped DEPS for public js api tests, fixed failures. (Closed)

Created:
3 years, 8 months ago by Mircea Trofin
Modified:
3 years, 8 months ago
Reviewers:
bradnelson, rossberg
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Bumped DEPS for public js api tests, fixed failures. This also fixes an existing discrepancy. BUG=v8:6017 Review-Url: https://codereview.chromium.org/2808403002 Cr-Commit-Position: refs/heads/master@{#44590} Committed: https://chromium.googlesource.com/v8/v8/+/53908d05b9ce2415871caadd61570aa27a8029d7

Patch Set 1 : [wasm] Bumped DEPS for public js api tests, fixed failures. #

Patch Set 2 : [wasm] Bumped DEPS for public js api tests, fixed failures. #

Patch Set 3 : [wasm] Bumped DEPS for public js api tests, fixed failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -35 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +22 lines, -18 lines 0 comments Download
M test/mjsunit/wasm/errors.js View 1 2 3 chunks +15 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 1 3 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/jsapi-harness.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (20 generated)
Mircea Trofin
3 years, 8 months ago (2017-04-11 15:47:31 UTC) #7
rossberg
LGTM
3 years, 8 months ago (2017-04-11 16:08:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808403002/80001
3 years, 8 months ago (2017-04-11 20:07:33 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 20:09:28 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/53908d05b9ce2415871caadd61570aa27a8...

Powered by Google App Engine
This is Rietveld 408576698