Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: test/mjsunit/wasm/errors.js

Issue 2808403002: [wasm] Bumped DEPS for public js api tests, fixed failures. (Closed)
Patch Set: [wasm] Bumped DEPS for public js api tests, fixed failures. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | test/mjsunit/wasm/js-api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/wasm/errors.js
diff --git a/test/mjsunit/wasm/errors.js b/test/mjsunit/wasm/errors.js
index b87702fa837b72a8601ea34655594b24f8088e03..5910bc34492ecfbcbc788da6be4972165a73c2b2 100644
--- a/test/mjsunit/wasm/errors.js
+++ b/test/mjsunit/wasm/errors.js
@@ -86,12 +86,24 @@ function assertConversionError(bytes, imports) {
assertCompileError(builder().addStart(0).toBuffer());
})();
-(function TestLinkingError() {
+(function TestTypeError() {
let b;
-
b = builder();
b.addImport("foo", "bar", kSig_v_v);
- assertLinkError(b.toBuffer(), {});
+ assertTypeError(b.toBuffer(), {});
+
+ b = builder();
+ b.addImportedGlobal("foo", "bar", kWasmI32);
+ assertTypeError(b.toBuffer(), {});
+
+ b = builder();
+ b.addImportedMemory("foo", "bar");
+ assertTypeError(b.toBuffer(), {});
+})();
+
+(function TestLinkingError() {
+ let b;
+
b = builder();
b.addImport("foo", "bar", kSig_v_v);
assertLinkError(b.toBuffer(), {foo: {}});
@@ -101,9 +113,6 @@ function assertConversionError(bytes, imports) {
b = builder();
b.addImportedGlobal("foo", "bar", kWasmI32);
- assertLinkError(b.toBuffer(), {});
- b = builder();
- b.addImportedGlobal("foo", "bar", kWasmI32);
assertLinkError(b.toBuffer(), {foo: {}});
b = builder();
b.addImportedGlobal("foo", "bar", kWasmI32);
@@ -114,9 +123,6 @@ function assertConversionError(bytes, imports) {
b = builder();
b.addImportedMemory("foo", "bar");
- assertLinkError(b.toBuffer(), {});
- b = builder();
- b.addImportedMemory("foo", "bar");
assertLinkError(b.toBuffer(), {foo: {}});
b = builder();
b.addImportedMemory("foo", "bar", 1);
« no previous file with comments | « src/wasm/wasm-module.cc ('k') | test/mjsunit/wasm/js-api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698