Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest

Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest

The parameterized template function RunCodecSupportTest is supposed to
invoke tested callback with different combinations of PlatformInfo settings,
but it actually used only initial values of PlatformInfo fields.

Also it seems that H264 is always supported for non-encrypted video, so the
test IsCodecSupportedOnAndroidTest.ClearCodecBehavior should be corrected.
This has been revealed only after fixing parameter variation.

Initial changeset https://codereview.chromium.org/2804883007 was reverted,
I was accessing a vector at index just before checking the index vs
vector size. This time I moved access of the states vector into loop body,
and split RUN_TEST_VECTOR into two macros: RUN_TEST_VECTOR_BEGIN and
RUN_TEST_VECTOR_END.

R=chcunningham, dalecurtis
BUG=709428
Review-Url: https://codereview.chromium.org/2808373002
Cr-Commit-Position: refs/heads/master@{#463968}
Committed: https://chromium.googlesource.com/chromium/src/+/56a00719145e7f3f690cbeabb6025e5420932782

[pavor, 2017-04-11 11:48:45]

On 2017/04/11 11:45:47, pavor wrote:

I do not have experience with reverted CLs, and I haven't really found an
instruction on chromium.org how to handle this, so I just cleared issue with git
cl issue 0 for the change branch and created another CL as the previous is
already closed.

[DaleCurtis, 2017-04-11 19:04:46]

This seems the same as the reverted CL? Am I blind? :)

https://codereview.chromium.org/2808373002/diff/1/media/base/mime_util_unitte...
File media/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/2808373002/diff/1/media/base/mime_util_unitte...
media/base/mime_util_unittest.cc:93: #undef RUN_TEST_VECTOR_BEGIN
Blank line above.

[DaleCurtis, 2017-04-11 19:07:13]

Oh I see, you accidentally uploaded to the old cl, which is why they look the
same. this fix lgtm.

[pavor, 2017-04-12 07:03:12]

On 2017/04/11 19:07:13, DaleCurtis wrote:
> Oh I see, you accidentally uploaded to the old cl, which is why they look the
> same. this fix lgtm.

Yeah, at first I thought git cl upload will automatically create a new CL, but
when I saw my changes appear in the old one, I searched for a way to unbind the
issue from git branch.

[pavor, 2017-04-12 07:03:50]

https://codereview.chromium.org/2808373002/diff/1/media/base/mime_util_unitte...
File media/base/mime_util_unittest.cc (right):

https://codereview.chromium.org/2808373002/diff/1/media/base/mime_util_unitte...
media/base/mime_util_unittest.cc:93: #undef RUN_TEST_VECTOR_BEGIN
On 2017/04/11 19:04:45, DaleCurtis wrote:
> Blank line above.
Done

[pavor, 2017-04-12 07:04:15]

The CQ bit was checked by pavor@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 07:04:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 08:07:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:07:49]

Dry run: This issue passed the CQ dry run.

[pavor, 2017-04-12 08:34:46]

The CQ bit was checked by pavor@yandex-team.ru

[pavor, 2017-04-12 08:34:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2808373002/#ps20001
(title: "add blank line above RUN_TEST_VECTOR_XXX undefs")

[commit-bot: I haz the power, 2017-04-12 08:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 09:03:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491986086547680,
"parent_rev": "49c67797cd9be6221b2d36bc35700c36dd00839d", "commit_rev":
"56a00719145e7f3f690cbeabb6025e5420932782"}

[commit-bot: I haz the power, 2017-04-12 09:04:28]

Description was changed from

==========
Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest

The parameterized template function RunCodecSupportTest is supposed to
invoke tested callback with different combinations of PlatformInfo settings,
but it actually used only initial values of PlatformInfo fields.

Also it seems that H264 is always supported for non-encrypted video, so the
test IsCodecSupportedOnAndroidTest.ClearCodecBehavior should be corrected.
This has been revealed only after fixing parameter variation.

Initial changeset https://codereview.chromium.org/2804883007 was reverted,
I was accessing a vector at index just before checking the index vs
vector size. This time I moved access of the states vector into loop body,
and split RUN_TEST_VECTOR into two macros: RUN_TEST_VECTOR_BEGIN and
RUN_TEST_VECTOR_END.

R=chcunningham, dalecurtis
BUG=709428
==========

to

==========
Fix PlatformInfo variation for mime util IsCodecSupportedOnAndroidTest

The parameterized template function RunCodecSupportTest is supposed to
invoke tested callback with different combinations of PlatformInfo settings,
but it actually used only initial values of PlatformInfo fields.

Also it seems that H264 is always supported for non-encrypted video, so the
test IsCodecSupportedOnAndroidTest.ClearCodecBehavior should be corrected.
This has been revealed only after fixing parameter variation.

Initial changeset https://codereview.chromium.org/2804883007 was reverted,
I was accessing a vector at index just before checking the index vs
vector size. This time I moved access of the states vector into loop body,
and split RUN_TEST_VECTOR into two macros: RUN_TEST_VECTOR_BEGIN and
RUN_TEST_VECTOR_END.

R=chcunningham, dalecurtis
BUG=709428

Review-Url: https://codereview.chromium.org/2808373002
Cr-Commit-Position: refs/heads/master@{#463968}
Committed:
https://chromium.googlesource.com/chromium/src/+/56a00719145e7f3f690cbeabb602...
==========

[commit-bot: I haz the power, 2017-04-12 09:04:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56a00719145e7f3f690cbeabb602...