Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2808273006: Landing Recent QUIC changes until Sun Apr 9 16:12:55 (Closed)

Created:
3 years, 8 months ago by danzh1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, cbentzel+watch_chromium.org, net-reviews_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until Sun Apr 9 16:12:55 Sync flag values with internal code. https://codereview.chromium.org/2812053003/ Adding using declarations for std::swap. Merge internal change: 152632013 https://codereview.chromium.org/2815733002/ Remove unused QUIC_TIMEOUTS_WITH_OPEN_STREAMS QuicErrorCode. n/a - dead code removal Merge internal change: 152550938 https://codereview.chromium.org/2814633005/ Makes a QUIC method non-const. Declares PacingSender::TimeUntilSend as non-const because it is. Merge internal change: 152543207 https://codereview.chromium.org/2812043003/ Pass the list of packets expected to be lost directly into VerifyLoss() as a C++ vector, as opposed to a C array. n/a (test-only change) Merge internal change: 152503943 https://codereview.chromium.org/2816583002/ Deprecate FLAGS_quic_reloadable_flag_quic_flow_control_invariant. n/a (Flag deprecation) Merge internal change: 152451230 https://codereview.chromium.org/2812003002/ add a field |accept_new_connection_| to QuicDispatcher as a switch to disallow creation of new connection. Merge internal change: 152397597 https://codereview.chromium.org/2815683002/ Change QUIC's GeneralLossAlgorithm to calculate the reordering threshold it needs for each spurious retransmit, rather than only the first in an epoch. Protected by FLAGS_quic_reloadable_flag_quic_fix_adaptive_time_loss. Merge internal change: 152396050 https://codereview.chromium.org/2807303002/ Replace quic_restart_flag_quic_big_endian_connection_id with quic_restart_flag_quic_big_endian_connection_id_client and quic_restart_flag_quic_big_endian_connection_id_server to protect connection ID endian change on client and server, respectively. Merge internal change: 152388928 https://codereview.chromium.org/2808893003/ Add QUIC v39 which will be used to experiment with HTTP/2 stream mapping and HoL free HPACK. Protected by quic_enable_version_39. Merge internal change: 152247824 https://codereview.chromium.org/2809773002/ Let QUIC_VERSION_38 support IETF PADDING frame (1 byte frame with type 0x00) and respect NSTP connection option. Protected by FLAGS_quic_reloadable_flag_quic_enable_version_38. Merge internal change: 152158483 https://codereview.chromium.org/2809723002/ Initialize buffer in test before adding it to a packet The buffer contents are logged, causing msan error in internal test. Merge internal change: 152114716 https://codereview.chromium.org/2810643004/ R=jri@chromium.org Review-Url: https://codereview.chromium.org/2808273006 Cr-Commit-Position: refs/heads/master@{#464804} Committed: https://chromium.googlesource.com/chromium/src/+/75104986e685df7cf9f44e4d4fcca97d19e9907c

Patch Set 1 #

Patch Set 2 : update kDeprecatedQuicErrorCount #

Patch Set 3 : increment enabled_options in e2e test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1151 lines, -582 lines) Patch
M chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc View 5 chunks +5 lines, -0 lines 0 comments Download
M components/domain_reliability/quic_error_mapping.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M components/domain_reliability/util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_response_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_response_info.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm.cc View 3 chunks +14 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 20 chunks +43 lines, -54 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_handshake_message.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 5 chunks +9 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 14 chunks +32 lines, -16 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/core/quic_data_reader.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_reader.cc View 3 chunks +12 lines, -1 line 0 comments Download
M net/quic/core/quic_data_writer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_data_writer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/core/quic_data_writer_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_error_codes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_error_codes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_flags_list.h View 5 chunks +26 lines, -14 lines 0 comments Download
M net/quic/core/quic_flow_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/quic_framer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer.cc View 4 chunks +46 lines, -4 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 87 chunks +586 lines, -312 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/quic/core/quic_session.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/core/quic_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_utils.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/core/quic_version_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/core/quic_version_manager.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M net/quic/core/quic_version_manager_test.cc View 3 chunks +19 lines, -7 lines 0 comments Download
M net/quic/core/quic_versions.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/core/quic_versions.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +37 lines, -18 lines 0 comments Download
M net/quic/test_tools/simulator/quic_endpoint_test.cc View 5 chunks +13 lines, -6 lines 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 10 chunks +114 lines, -80 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +13 lines, -8 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 4 chunks +20 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 3 chunks +33 lines, -4 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 53 (33 generated)
danzh1
3 years, 8 months ago (2017-04-12 14:42:07 UTC) #2
Jana
lgtm
3 years, 8 months ago (2017-04-12 18:33:38 UTC) #13
Jana
+csharrison for page_load_metrics +rch for domain_reliability
3 years, 8 months ago (2017-04-12 18:40:39 UTC) #15
Jana
3 years, 8 months ago (2017-04-12 18:40:55 UTC) #17
Ryan Hamilton
domain_reliability: LGTM
3 years, 8 months ago (2017-04-12 18:42:05 UTC) #18
Charlie Harrison
LGTM
3 years, 8 months ago (2017-04-12 18:43:45 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808273006/20001
3 years, 8 months ago (2017-04-13 14:04:48 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/410418)
3 years, 8 months ago (2017-04-13 14:15:10 UTC) #25
danzh1
On 2017/04/12 18:42:05, Ryan Hamilton wrote: > domain_reliability: LGTM Why presubmit still complains about missing ...
3 years, 8 months ago (2017-04-13 14:43:41 UTC) #27
Jana
+juliatuttle for domain_reliability/util.cc
3 years, 8 months ago (2017-04-13 18:49:31 UTC) #29
Julia Tuttle
domain_reliability lgtm
3 years, 8 months ago (2017-04-13 19:25:46 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808273006/20001
3 years, 8 months ago (2017-04-13 20:18:01 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/349534)
3 years, 8 months ago (2017-04-13 23:28:49 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808273006/20001
3 years, 8 months ago (2017-04-13 23:52:28 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/349650)
3 years, 8 months ago (2017-04-14 03:07:34 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808273006/20001
3 years, 8 months ago (2017-04-14 04:00:47 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/349783)
3 years, 8 months ago (2017-04-14 06:54:26 UTC) #42
danzh1
On 2017/04/12 18:42:05, Ryan Hamilton wrote: > domain_reliability: LGTM I added patch set #3. PTAL
3 years, 8 months ago (2017-04-14 20:05:52 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808273006/40001
3 years, 8 months ago (2017-04-14 21:22:16 UTC) #50
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 21:59:31 UTC) #53
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75104986e685df7cf9f44e4d4fcc...

Powered by Google App Engine
This is Rietveld 408576698