Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2808893003: Replace quic_restart_flag_quic_big_endian_connection_id with quic_restart_flag_quic_big_endian_conn… (Closed)

Created:
3 years, 8 months ago by danzh1
Modified:
3 years, 8 months ago
Reviewers:
Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace quic_restart_flag_quic_big_endian_connection_id with quic_restart_flag_quic_big_endian_connection_id_client and quic_restart_flag_quic_big_endian_connection_id_server to protect connection ID endian change on client and server, respectively. Merge internal change: 152388928 R=jri@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+686 lines, -462 lines) Patch
M net/quic/core/congestion_control/bbr_sender_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/send_algorithm_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_handshake_message.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 14 chunks +32 lines, -16 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/core/quic_data_reader.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_data_writer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_data_writer_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 2 chunks +12 lines, -4 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 87 chunks +407 lines, -320 lines 0 comments Download
M net/quic/core/quic_utils.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_utils.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +37 lines, -18 lines 0 comments Download
M net/quic/test_tools/simulator/quic_endpoint_test.cc View 5 chunks +13 lines, -6 lines 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 9 chunks +107 lines, -79 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (4 generated)
danzh1
3 years, 8 months ago (2017-04-11 14:49:35 UTC) #1
Jana
3 years, 8 months ago (2017-04-11 17:47:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698