Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2808253003:
[Chromecast] Make static_config a noop for clang builds (Closed)
Description[Chromecast] Make static_config a noop for clang builds
Previously this was guarded with use_clang on shared_library_config, but
some targets use static_config directly.
BUG=b/37232530
TEST=Build and run device. Check {C/LD}FLAGS
Review-Url: https://codereview.chromium.org/2808253003
Cr-Commit-Position: refs/heads/master@{#463795}
Committed: https://chromium.googlesource.com/chromium/src/+/58a97b349697f6764d0d0304a8374da957ef2207
Patch Set 1 #
Total comments: 4
Messages
Total messages: 17 (9 generated)
Description was changed from
==========
[Chromecast] Make static_config a noop for clang builds
Previously this was guarded with use_clang on shared_library_config, but
some targets use static_config directly.
BUG=b/37232530
TEST=Build and run device. Check {C/LD}FLAGS
==========
to
==========
[Chromecast] Make static_config a noop for clang builds
Previously this was guarded with use_clang on shared_library_config, but
some targets use static_config directly.
BUG=b/37232530
TEST=Build and run device. Check {C/LD}FLAGS
==========
bcf@chromium.org changed reviewers: + brettw@chromium.org, dpranke@chromium.org, gfhuang@chromium.org, slan@chromium.org, wzhong@chromium.org
On 2017/04/11 17:43:09, bcf wrote: lgtm
https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... File build/config/chromecast/BUILD.gn (right): https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... build/config/chromecast/BUILD.gn:16: ] is this safe to remove?
lgtm https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... File build/config/chromecast/BUILD.gn (right): https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... build/config/chromecast/BUILD.gn:16: ] On 2017/04/11 17:54:27, gfhuang wrote: > is this safe to remove? No. Still needed for GCC build. https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... build/config/chromecast/BUILD.gn:23: "-static-libgcc", What is the implication in practice? Does clang take those flags?
https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... File build/config/chromecast/BUILD.gn (right): https://codereview.chromium.org/2808253003/diff/1/build/config/chromecast/BUI... build/config/chromecast/BUILD.gn:23: "-static-libgcc", On 2017/04/11 17:57:41, wzhong wrote: > What is the implication in practice? > > Does clang take those flags? Yes, clang will take the flags. In practice this means clang builds will use shared libc++, statically link libgcc, and statically link libstdc++. Since we're using libc++, statically linking libstdc++ probably won't actually bring in anything.
lgtm
The CQ bit was checked by bcf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bcf@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491947464399080, "parent_rev":
"eb295005bb1c6c408e4229f48da048b7ebe7efa1", "commit_rev":
"58a97b349697f6764d0d0304a8374da957ef2207"}
Message was sent while issue was closed.
Description was changed from
==========
[Chromecast] Make static_config a noop for clang builds
Previously this was guarded with use_clang on shared_library_config, but
some targets use static_config directly.
BUG=b/37232530
TEST=Build and run device. Check {C/LD}FLAGS
==========
to
==========
[Chromecast] Make static_config a noop for clang builds
Previously this was guarded with use_clang on shared_library_config, but
some targets use static_config directly.
BUG=b/37232530
TEST=Build and run device. Check {C/LD}FLAGS
Review-Url: https://codereview.chromium.org/2808253003
Cr-Commit-Position: refs/heads/master@{#463795}
Committed:
https://chromium.googlesource.com/chromium/src/+/58a97b349697f6764d0d0304a837...
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/58a97b349697f6764d0d0304a837... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
