[Chromecast] Make static_config a noop for clang builds

build/config/chromecast/BUILD.gn

Index: build/config/chromecast/BUILD.gn
diff --git a/build/config/chromecast/BUILD.gn b/build/config/chromecast/BUILD.gn
index 60cb52cc4b88d7ffd3c91c239a1e1607c2803b75..3c99eba50f0476312277ab50944f8fc3052786b6 100644
--- a/build/config/chromecast/BUILD.gn
+++ b/build/config/chromecast/BUILD.gn
@@ -7,20 +7,22 @@ import("//build/config/chromecast_build.gni")
 assert(is_chromecast)
 
 config("static_config") {
-  ldflags = [
-    # Don't allow visible symbols from libraries that contain
-    # assembly code with symbols that aren't hidden properly.
-    # http://b/26390825
-    "-Wl,--exclude-libs=libffmpeg.a",
-  ]
-
-  if (!is_android) {
-    ldflags += [
-      # We want to statically link libstdc++/libgcc on Linux.
-      # (On Android, libstdc++ and libgcc aren't used.)
-      "-static-libstdc++",
-      "-static-libgcc",
+  if (!is_clang) {
+    ldflags = [
+      # Don't allow visible symbols from libraries that contain
+      # assembly code with symbols that aren't hidden properly.
+      # http://b/26390825
+      "-Wl,--exclude-libs=libffmpeg.a",
     ]

[gfhuang, 2017/04/11 17:54:27]

is this safe to remove?

[wzhong, 2017/04/11 17:57:41]

No. Still needed for GCC build.

+
+    if (!is_android) {
+      ldflags += [
+        # We want to statically link libstdc++/libgcc on Linux.
+        # (On Android, libstdc++ and libgcc aren't used.)
+        "-static-libstdc++",
+        "-static-libgcc",

[wzhong, 2017/04/11 17:57:41]

What is the implication in practice?

Does clang take those flags?

[bcf, 2017/04/11 18:17:07]

Yes, clang will take the flags.

In practice this means clang builds will use shared libc++, statically link
libgcc, and statically link libstdc++. Since we're using libc++, statically
linking libstdc++ probably won't actually bring in anything.

+      ]
+    }
   }
 }
 
@@ -75,7 +77,7 @@ config("executable_config") {
 
 config("shared_library_config") {
   configs = [ ":ldconfig" ]
-  if (!is_clang && current_cpu == "arm") {
+  if (current_cpu == "arm") {
     configs += [ ":static_config" ]
   }
 }