Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2808203004: Instant Apps: Be extra safe with the flag check. (Closed)

Created:
3 years, 8 months ago by Maria
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Be extra safe with the flag check. I just thought of the possibility that OEMs may have found other uses for unused flag ids. This flag is only defined in O, so let's only check for it in O to ensure we aren't capturing any weird OEM-customized edge cases. BUG=710497 Review-Url: https://codereview.chromium.org/2813993002 Cr-Commit-Position: refs/heads/master@{#463841} (cherry picked from commit 8152d2adcabba8e58d47308f233f2619230fe711) Review-Url: https://codereview.chromium.org/2808203004 . Cr-Commit-Position: refs/branch-heads/3029@{#674} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/cb65deb6746cd262ff82bef478127e34d0110fd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Maria
3 years, 8 months ago (2017-04-12 00:34:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb65deb6746cd262ff82bef478127e34d0110fd2.

Powered by Google App Engine
This is Rietveld 408576698