Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2813993002: Instant Apps: Be extra safe with the flag check. (Closed)

Created:
3 years, 8 months ago by Maria
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant Apps: Be extra safe with the flag check. I just thought of the possibility that OEMs may have found other uses for unused flag ids. This flag is only defined in O, so let's only check for it in O to ensure we aren't capturing any weird OEM-customized edge cases. BUG=710497 Review-Url: https://codereview.chromium.org/2813993002 Cr-Commit-Position: refs/heads/master@{#463841} Committed: https://chromium.googlesource.com/chromium/src/+/8152d2adcabba8e58d47308f233f2619230fe711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Maria
3 years, 8 months ago (2017-04-11 22:57:51 UTC) #2
Ted C
lgtm
3 years, 8 months ago (2017-04-11 22:59:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813993002/1
3 years, 8 months ago (2017-04-11 23:04:50 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 23:52:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8152d2adcabba8e58d47308f233f...

Powered by Google App Engine
This is Rietveld 408576698