Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2808013003:
Deflake background-image-relative-url-in-iframe.html (Closed)
|
Created:
3 years, 8 months ago by suzyh_UTC10 (ex-contributor) Modified:
3 years, 8 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeflake background-image-relative-url-in-iframe.html
Deflake LayoutTests/fast/backgrounds/ test
background-image-relative-url-in-iframe.html by delaying testRunner
completion until iframe load event fires.
iframe.contentDocument.body.innerHTML has been replaced with
iframe.srcdoc in order to cause the load event to retrigger.
BUG=708934
Review-Url: https://codereview.chromium.org/2808013003
Cr-Commit-Position: refs/heads/master@{#465176}
Committed: https://chromium.googlesource.com/chromium/src/+/71abad621416fd3cbb69ebb2dae0d90b84be0287
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use testRunner.notifyDone instead of preload #Patch Set 3 : Move notifyDone clause after srcdoc assignment #Patch Set 4 : Rebase #
Messages
Total messages: 24 (13 generated)
The CQ bit was checked by suzyh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
suzyh@chromium.org changed reviewers: + shoon.kim@lge.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM Thanks for fixing.
The CQ bit was checked by suzyh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
suzyh@chromium.org changed reviewers: + rune@opera.com
+rune as reviewer of the CL that added this test.
https://codereview.chromium.org/2808013003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html (right): https://codereview.chromium.org/2808013003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html:6: <link rel='preload' href='./resources/green-24x24.png' as='image'> Will rel=preload guarantee that the resource will be loaded for the first paint here? If so, lgtm. Otherwise, waiting on a load event would be safer?
Description was changed from ========== Deflake background-image-relative-url-in-iframe.html Deflake LayoutTests/fast/backgrounds/ test background-image-relative-url-in-iframe.html by adding a preload for the image file required. BUG=708934 ========== to ========== Deflake background-image-relative-url-in-iframe.html Deflake LayoutTests/fast/backgrounds/ test background-image-relative-url-in-iframe.html by delaying testRunner completion until iframe load event fires. iframe.contentDocument.body.innerHTML has been replaced with iframe.srcdoc in order to cause the load event to retrigger. BUG=708934 ==========
Thanks rune, PTAL https://codereview.chromium.org/2808013003/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html (right): https://codereview.chromium.org/2808013003/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html:6: <link rel='preload' href='./resources/green-24x24.png' as='image'> On 2017/04/11 at 07:43:26, rune wrote: > Will rel=preload guarantee that the resource will be loaded for the first paint here? If so, lgtm. Otherwise, waiting on a load event would be safer? The preload spec says "The preload link element must not delay the load event of the element's node document." so I guess no, there's no guarantees. Rewritten to use onload=testRunner.notifyDone instead.
Ping rune: PTAL
lgtm
The CQ bit was checked by suzyh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shoon.kim@lge.com Link to the patchset: https://codereview.chromium.org/2808013003/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492499588981840,
"parent_rev": "f9774e4bbc3820cff53edeb95f5562ae69dc391a", "commit_rev":
"71abad621416fd3cbb69ebb2dae0d90b84be0287"}
Message was sent while issue was closed.
Description was changed from ========== Deflake background-image-relative-url-in-iframe.html Deflake LayoutTests/fast/backgrounds/ test background-image-relative-url-in-iframe.html by delaying testRunner completion until iframe load event fires. iframe.contentDocument.body.innerHTML has been replaced with iframe.srcdoc in order to cause the load event to retrigger. BUG=708934 ========== to ========== Deflake background-image-relative-url-in-iframe.html Deflake LayoutTests/fast/backgrounds/ test background-image-relative-url-in-iframe.html by delaying testRunner completion until iframe load event fires. iframe.contentDocument.body.innerHTML has been replaced with iframe.srcdoc in order to cause the load event to retrigger. BUG=708934 Review-Url: https://codereview.chromium.org/2808013003 Cr-Commit-Position: refs/heads/master@{#465176} Committed: https://chromium.googlesource.com/chromium/src/+/71abad621416fd3cbb69ebb2dae0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/71abad621416fd3cbb69ebb2dae0... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
