third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html - Issue 2808013003: Deflake background-image-relative-url-in-iframe.html

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html

Issue 2808013003: Deflake background-image-relative-url-in-iframe.html (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <iframe id="iframe"></iframe>	2 <iframe id="iframe"></iframe>

3 <script>	3 <script>

4 var iframe = document.getElementById('iframe');	4 var iframe = document.getElementById('iframe');

5 iframe.contentDocument.body.innerHTML = `	5 iframe.contentDocument.body.innerHTML = `

	6 <link rel='preload' href='./resources/green-24x24.png' as='image'>
	rune 2017/04/11 07:43:26 Will rel=preload guarantee that the resource will Will rel=preload guarantee that the resource will be loaded for the first paint here? If so, lgtm. Otherwise, waiting on a load event would be safer? suzyh_UTC10 (ex-contributor) 2017/04/12 05:16:26 The preload spec says "The preload link element mu Show quoted text On 2017/04/11 at 07:43:26, rune wrote: > Will rel=preload guarantee that the resource will be loaded for the first paint here? If so, lgtm. Otherwise, waiting on a load event would be safer? The preload spec says "The preload link element must not delay the load event of the element's node document." so I guess no, there's no guarantees. Rewritten to use onload=testRunner.notifyDone instead.
6 <style>	7 <style>

7 .bg-img {	8 .bg-img {

8 background: url('./resources/green-24x24.png') no-repeat;	9 background: url('./resources/green-24x24.png') no-repeat;

9 width: 24px;	10 width: 24px;

10 height:24px;	11 height:24px;

11 }	12 }

12 </style>	13 </style>

13 <div class='bg-img'></div>`;	14 <div class='bg-img'></div>`;

14 </script>	15 </script>

OLD	NEW

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »