third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h ('K') | « third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBuffer.cpp ('k') | third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

index 94988e09aa4ff8c6904ab3df33e6039cb6d67860..71886bb6816f508ae02811a498ad1cf5fc183d71 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultSpacing.cpp

@@ -42,7 +42,7 @@ ShapeResultSpacing::ShapeResultSpacing(const TextRun& run,

m_expansionOpportunityCount =

Character::expansionOpportunityCount(run, isAfterExpansion);

if (isAfterExpansion && !run.allowsTrailingExpansion()) {

- ASSERT(m_expansionOpportunityCount > 0);

+ DCHECK_GT(m_expansionOpportunityCount, 0u);

--m_expansionOpportunityCount;

}

@@ -52,7 +52,7 @@ ShapeResultSpacing::ShapeResultSpacing(const TextRun& run,

float ShapeResultSpacing::nextExpansion() {

if (!m_expansionOpportunityCount) {

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return 0;

}