Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: third_party/checkstyle/README.chromium

Issue 2807753003: Revert "Update third_party/checkstyle to 7.6.1" (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/checkstyle/OWNERS ('k') | third_party/checkstyle/checkstyle-6.5-all.jar » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Name: Checkstyle is a development tool to help programmers write Java code that 1 Name: Checkstyle is a development tool to help programmers write Java code that
2 adheres to a coding standard. 2 adheres to a coding standard.
3 Short Name: checkstyle 3 Short Name: checkstyle
4 URL: https://github.com/checkstyle/checkstyle 4 URL: http://checkstyle.sourceforge.net/
5 Version: 7.6.1 5 Version: 6.5
6 License: LGPL 2.1 6 License: LGPL 2.1
7 License File: NOT_SHIPPED 7 License File: NOT_SHIPPED
8 Security Critical: no 8 Security Critical: no
9 9
10 Description: 10 Description:
11 Checkstyle is used to validate Java code style on Chromium PRESUBMIT step. 11 Checkstyle is used to validate Java code style on Chromium PRESUBMIT step.
12 12
13 Local Modifications: 13 Local Modifications:
14 None 14 - Downloaded checkstyle-6.5-all.jar without source code development
15 15 documentation.
16 Update instructions (requires @google.com account):
17 - Download fat jar from https://sourceforge.net/projects/checkstyle/files/checks tyle/
18 - Modify tools/android/checkstyle/checkstyle.py and verify the new fat jar works
19 - Remove existing SHA1 file
20 - If gcloud auth tokens are not set up, run
21 $ download_from_google_storage --config
22 - Upload new fat jar to gcloud. In third_party/checkstyle, run
23 $ upload_to_google_storage.py -b chromium-android-tools/checkstyle {new_far_jar}
24 - Check in new SHA1 file
25
OLDNEW
« no previous file with comments | « third_party/checkstyle/OWNERS ('k') | third_party/checkstyle/checkstyle-6.5-all.jar » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698