Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2697)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java

Issue 2807663002: 📺 Move fullscreen web content to a new Activity. (Closed)
Patch Set: Considered other ChromeActivity subclasses. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java
new file mode 100644
index 0000000000000000000000000000000000000000..1ec8ab56f4de2d9f3f34fe28f27ede3ce47cc50e
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/FullscreenWebContentsActivity.java
@@ -0,0 +1,49 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser;
+
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
+import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;
+import org.chromium.chrome.browser.tabmodel.TabReparentingParams;
+import org.chromium.chrome.browser.util.IntentUtils;
+import org.chromium.chrome.browser.webapps.FullScreenActivity;
+
+/**
+ * An Activity used to display fullscreen WebContents.
+ */
+public class FullscreenWebContentsActivity extends FullScreenActivity {
+ @Override
+ protected Tab createTab() {
+ assert getIntent().hasExtra(IntentHandler.EXTRA_TAB_ID);
+
+ int tabId = IntentUtils.safeGetIntExtra(
+ getIntent(), IntentHandler.EXTRA_TAB_ID, Tab.INVALID_TAB_ID);
+ TabReparentingParams params = (TabReparentingParams) AsyncTabParamsManager.remove(tabId);
+
+ Tab tab = params.getTabToReparent();
+ tab.attachAndFinishReparenting(this, createTabDelegateFactory(), params);
+ return tab;
+ }
+
+ @Override
+ protected int getControlContainerLayoutId() {
+ // TODO(peconn): Determine if there's something more suitable to use here.
+ return R.layout.webapp_control_container;
+ }
+
+ @Override
+ protected ChromeFullscreenManager createFullscreenManager() {
+ // Create a Fullscreen manager that won't change the Tab's fullscreen state when the
+ // Activity ends - we handle leaving fullscreen ourselves.
+ return new ChromeFullscreenManager(this, false, false);
+ }
+
+ @Override
+ public boolean supportsFullscreenActivity() {
+ return true;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698