Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2807663002: 📺 Move fullscreen web content to a new Activity. (Closed)
Patch Set: Considered other ChromeActivity subclasses. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index ff9504bcf0c9084f01decdb648f84258a397144f..5e6229a3f7e56d88764b30b0665fcc2898ebf27a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -1390,7 +1390,7 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
final Tab currentTab = getActivityTab();
boolean currentTabIsNtp = currentTab != null && NewTabPage.isNTPUrl(currentTab.getUrl());
if (id == R.id.move_to_other_window_menu_id) {
- if (currentTab != null) moveTabToOtherWindow(currentTab);
+ if (currentTab != null) MultiWindowUtils.moveTabToOtherWindow(this, currentTab);
} else if (id == R.id.new_tab_menu_id) {
getTabModelSelector().getModel(false).commitAllTabClosures();
RecordUserAction.record("MobileMenuNewTab");
@@ -1497,18 +1497,6 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
}
- private void moveTabToOtherWindow(Tab tab) {
- Class<? extends Activity> targetActivity =
- MultiWindowUtils.getInstance().getOpenInOtherWindowActivity(this);
- if (targetActivity == null) return;
-
- Intent intent = new Intent(this, targetActivity);
- MultiWindowUtils.setOpenInOtherWindowIntentExtras(intent, this, targetActivity);
- MultiWindowUtils.onMultiInstanceModeStarted();
-
- tab.detachAndStartReparenting(intent, null, null);
- }
-
@Override
public boolean handleBackPressed() {
if (!mUIInitialized) return false;
@@ -2011,4 +1999,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
return false;
}
+
+ @Override
+ public boolean supportsFullscreenActivity() {
+ return true;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698