Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2807563002: [turbofan] Also run the CheckpointElimination as part of load elimination. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also run the CheckpointElimination as part of load elimination. The LoadElimination (and potentially earlier passes too) might have removed or lowered side-effecting operations, which allows for further combining of check points in the graph, removing unnecessary StateValue uses for the later truncation analysis. BUG=chromium:709398 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2807563002 Cr-Commit-Position: refs/heads/master@{#44486} Committed: https://chromium.googlesource.com/v8/v8/+/1be5279bcc52c37287d0090ade4f375dcf809ada

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-07 12:07:14 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-07 12:12:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807563002/1
3 years, 8 months ago (2017-04-07 12:12:58 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:32:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1be5279bcc52c37287d0090ade4f375dcf8...

Powered by Google App Engine
This is Rietveld 408576698