Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2802113003: [turbofan] Introduce a SpeculativeToNumber operator. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce a SpeculativeToNumber operator. Add a dedicated operator for ToNumber(x) with feedback instead of translating to SpeculativeNumberMultiply(x,1), which allows us to treat the case where x is already a Number specially, ignoring the feedback on the operator. This recovers most of the regression in the crypto benchmark. BUG=chromium:709398, v8:6214, v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2802113003 Cr-Commit-Position: refs/heads/master@{#44484} Committed: https://chromium.googlesource.com/v8/v8/+/e6ca01463de333bd4069d23c616c26647897e749

Patch Set 1 #

Patch Set 2 : Paint it green! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -27 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M src/compiler/js-type-hint-lowering.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-type-hint-lowering.cc View 3 chunks +42 lines, -16 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/loop-variable-optimizer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/operation-typer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/operation-typer.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 3 chunks +30 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 3 chunks +38 lines, -1 line 0 comments Download
M src/compiler/typed-optimization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typed-optimization.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-07 10:43:14 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-07 11:12:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802113003/20001
3 years, 8 months ago (2017-04-07 11:15:53 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:12:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e6ca01463de333bd4069d23c616c2664789...

Powered by Google App Engine
This is Rietveld 408576698