Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2807533005: Avoid duplicate functions/code in core/inspector: IsErrorStatusCode (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicate functions/code in core/inspector: isErrorStatusCode While experimenting with unity builds I encountered a few duplicate symbols and functions in core/inspector. One of them was isErrorStatusCode, a one instruction function that was defined in both NetworkResourcesData.cpp and InspectorNetworkAgent.cpp. This patch renames one of them IsHTTPErrorStatusCode, a more suitable name. Review-Url: https://codereview.chromium.org/2807533005 Cr-Commit-Position: refs/heads/master@{#464076} Committed: https://chromium.googlesource.com/chromium/src/+/4624411ae3f604ce2e6ff453be42cf7e61b6ca30

Patch Set 1 #

Patch Set 2 : Rebased past blink rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Daniel Bratell
Please take a look.
3 years, 8 months ago (2017-04-07 19:58:46 UTC) #3
alph
lgtm
3 years, 8 months ago (2017-04-10 08:14:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807533005/20001
3 years, 8 months ago (2017-04-12 15:00:29 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 17:50:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4624411ae3f604ce2e6ff453be42...

Powered by Google App Engine
This is Rietveld 408576698