Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

Issue 2807533005: Avoid duplicate functions/code in core/inspector: IsErrorStatusCode (Closed)
Patch Set: Rebased past blink rename Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
diff --git a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
index f22d94d62cf626b90486d0687e81b89b27a65265..3a46dac3deb39b3c8997efd30cbc38d7bca1f361 100644
--- a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
+++ b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
@@ -36,7 +36,7 @@
namespace blink {
-static bool IsErrorStatusCode(int status_code) {
+static bool IsHTTPErrorStatusCode(int status_code) {
return status_code >= 400;
}
@@ -138,7 +138,8 @@ void NetworkResourcesData::ResourceData::ClearWeakMembers(Visitor* visitor) {
// Mark loaded resources or resources without the buffer as loaded.
if (cached_resource_->IsLoaded() || !cached_resource_->ResourceBuffer()) {
- if (!IsErrorStatusCode(cached_resource_->GetResponse().HttpStatusCode())) {
+ if (!IsHTTPErrorStatusCode(
+ cached_resource_->GetResponse().HttpStatusCode())) {
String content;
bool base64_encoded;
if (InspectorPageAgent::CachedResourceContent(cached_resource_, &content,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698