[Payments] After adding/editing a credit card, instrument is selected.

[Payments] After adding/editing a credit card, instrument is selected.

After being done editing an incomplete card, or adding a new one, the
instrument is selected for payment.

Still TODO is to go back to the payment sheet after the editor has
returned.

BUG=709571
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2807363003
Cr-Commit-Position: refs/heads/master@{#464148}
Committed: https://chromium.googlesource.com/chromium/src/+/24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81

[Mathieu, 2017-04-11 19:42:16]

Patchset #1 (id:1) has been deleted

[Mathieu, 2017-04-11 19:45:57]

mathp@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Mathieu, 2017-04-11 19:45:57]

Hi Anthony, 

Tried various approaches for this, and this one works. There is a slight "order
of operations" issue in general which makes it that the list views can't really
be PaymentRequestState observers, because as soon as you call say,
SetSelectedInstrument, the view would relayout, and you still haven't touched
the PaymentRequestItemList at that point. Coupled with the fact that
PaymentRequestItemList is stateful (doesn't rely on a relayout but rather keeps
|selected_item_|), it meant that I preferred calling list->SelectItem(item) and
UpdateContentView() manually, once I knew that my PaymentRequestState model was
A-OK. 

Anyway if it's not too ugly for you I suggest that we go ahead with an approach
like this. Let me know what you think.

[Mathieu, 2017-04-12 17:10:06]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:10:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-12 17:11:35]

Description was changed from

==========
[Payments] When adding/editing a credit card, propagate effect to list

Draft: description to follow.

BUG=709571
==========

to

==========
[Payments] After adding/editing a credit card, instrument is selected.

After being done editing an incomplete card, or adding a new one, the
instrument is selected for payment.

Still TODO is to go back to the payment sheet after the editor has
returned.

BUG=709571
TEST=browser_tests
==========

[Mathieu, 2017-04-12 17:11:50]

Hi Anthony, PTAL

[Mathieu, 2017-04-12 19:05:09]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[anthonyvd, 2017-04-12 19:05:31]

LGTM, thanks!

[commit-bot: I haz the power, 2017-04-12 19:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-12 19:07:10]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-12 19:07:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/2807363003/#ps110001
(title: "include fix")

[commit-bot: I haz the power, 2017-04-12 19:08:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:56:48]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1492024030874560,
"parent_rev": "ac2e0aeea11a2641dfca4d1b192bd1641b5cd5d3", "commit_rev":
"24ce4cde5a1d9f21ff63d0560f904dbd2dc46d81"}

[commit-bot: I haz the power, 2017-04-12 20:57:51]

Description was changed from

==========
[Payments] After adding/editing a credit card, instrument is selected.

After being done editing an incomplete card, or adding a new one, the
instrument is selected for payment.

Still TODO is to go back to the payment sheet after the editor has
returned.

BUG=709571
TEST=browser_tests
==========

to

==========
[Payments] After adding/editing a credit card, instrument is selected.

After being done editing an incomplete card, or adding a new one, the
instrument is selected for payment.

Still TODO is to go back to the payment sheet after the editor has
returned.

BUG=709571
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2807363003
Cr-Commit-Position: refs/heads/master@{#464148}
Committed:
https://chromium.googlesource.com/chromium/src/+/24ce4cde5a1d9f21ff63d0560f90...
==========

[commit-bot: I haz the power, 2017-04-12 20:57:52]

Committed patchset #6 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/24ce4cde5a1d9f21ff63d0560f90...